Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete undefined key triggers error #244

Open
swedmike opened this issue May 7, 2016 · 0 comments
Open

Delete undefined key triggers error #244

swedmike opened this issue May 7, 2016 · 0 comments

Comments

@swedmike
Copy link

swedmike commented May 7, 2016

Running a delete on urlOptions[label][attr] at line 1559 triggers an undefined error if the label is not there, which will stop JS execution and thus show the processindicator forever, making the table unusable.

The fix is obviously a small check:

if ("label" in urlOptions && "attr" in urlOptions[label]) {
  delete urlOptions[label][attr];
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant