Remove unwrapArray #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused API of page.onResourceRequested to change with phantom 1.9.0 (first argument was `request`, it became an array [`request`, `networkRequest`]). Now use fn.apply to pass arguments as they are received. This ensure that any change in phantomjs is transparently reflected without interference from node-phantom. NOTE: This change the API of onError and onPrompt which where already affected by this bug. They now get the same parameters as described on https://github.com/ariya/phantomjs/wiki/API-Reference-WebPage.
|
I like this. It is however a change that would break existing code so I will meditate some more on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused API of page.onResourceRequested to change with phantom
1.9.0 (first argument was
request, it became an array [request,networkRequest]).Now use fn.apply to pass arguments as they are received. This ensure
that any change in phantomjs is transparently reflected without
interference from node-phantom.
NOTE: This change the API of onError and onPrompt which where already
affected by this bug. They now get the same parameters as described on
https://github.com/ariya/phantomjs/wiki/API-Reference-WebPage.