Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Factor cost matrix in dense case #50

Closed
wants to merge 15 commits into from
Closed

[FEAT] Factor cost matrix in dense case #50

wants to merge 15 commits into from

Conversation

pbarbarant
Copy link
Collaborator

@pbarbarant pbarbarant commented May 13, 2024 •
edited
Loading

Solves #49 . Dense mappings now use Nystroem approximation by default for the cost matrix. Closes #49

  • Fixed dense solver/mapping
  • Adapted coarse-to-fine procedure
  • Adapt examples in the doc

Pierre-Louis Barbarant and others added 13 commits May 7, 2024 18:41
@pbarbarant pbarbarant added the enhancement New feature or request label May 13, 2024
bthirion
bthirion reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looks like it broke docs generation

src/fugw/scripts/coarse_to_fine.py Outdated Show resolved Hide resolved
src/fugw/solvers/dense.py Show resolved Hide resolved
bthirion
bthirion reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. There is still a doc building failure...

@pbarbarant
Copy link
Collaborator Author

OK. There is still a doc building failure...

That was expected as the examples using the dense solvers need to receive the embeddings instead of the cost matrix. I'll rewrite them so that it is clear for the user.

@bthirion
Copy link
Collaborator

I suggest to open an issue if you don't address it in this PR.
The PR LGTM otherwise.

@pbarbarant pbarbarant mentioned this pull request May 16, 2024
Closed
@pbarbarant pbarbarant closed this Oct 13, 2024
@pbarbarant pbarbarant deleted the feat/factor-cost-matrix branch October 13, 2024 23:15
@pbarbarant pbarbarant restored the feat/factor-cost-matrix branch October 13, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthirion bthirion bthirion left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Dense mappings should factor cost matrix by default
2 participants
@pbarbarant @bthirion