Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to add a Nonce to request #65

Open
muyiwaoyeniyi opened this issue Oct 28, 2020 · 1 comment · May be fixed by #120
Open

Option to add a Nonce to request #65

muyiwaoyeniyi opened this issue Oct 28, 2020 · 1 comment · May be fixed by #120
Assignees
@alexandrtovmach
Labels
enhancement New feature or request

Comments

@muyiwaoyeniyi
Copy link

Would it be possible to add a nonce to the request to mitigate timing attacks with the tokens returned? Also, an option to pass a State prop would be great too.

Thanks.
@muyiwaoyeniyi muyiwaoyeniyi added enhancement New feature or request question Further information is requested labels Oct 28, 2020
@alexandrtovmach
Copy link
Owner

Yeah, sounds reasonable. I'll take a look, but any PR or help are welcome

@alexandrtovmach alexandrtovmach removed the question Further information is requested label May 10, 2021
@noahhaon noahhaon linked a pull request Sep 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandrtovmach alexandrtovmach

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for state parameter noahhaon/react-microsoft-login
2 participants
@muyiwaoyeniyi @alexandrtovmach