Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setMode7Rot: Unexpected behavior when angle > 200 #206

Closed
malayli opened this issue Apr 26, 2023 · 7 comments
Closed

setMode7Rot: Unexpected behavior when angle > 200 #206

malayli opened this issue Apr 26, 2023 · 7 comments

Comments

@malayli
Copy link
Collaborator

malayli commented Apr 26, 2023

Description

When angle > 200, the rotation becomes unexpected.

You can test this issue by testing this example here on develop branch:
https://github.com/alekmaul/pvsneslib/tree/develop/snes-examples/graphics/Backgrounds/Mode7

@alekmaul
Copy link
Owner

alekmaul commented May 2, 2023

ok, I think the problem is the use of byte instead of words for matrix registers
i will test it soon (i'm added a new function for mode7 scaling too)

@malayli
Copy link
Collaborator Author

malayli commented May 9, 2023

@alekmaul Ok nice!

@jeffythedragonslayer
Copy link
Contributor

Can you elaborate on "unexpected?"

@malayli
Copy link
Collaborator Author

malayli commented Aug 11, 2023

@jeffythedragonslayer Difficult to explain it with words. I can share a video capture on PVSnesLib Discord.

@jeffythedragonslayer
Copy link
Contributor

A screenshot here wouldn't be good enough?

@malayli
Copy link
Collaborator Author

malayli commented Aug 11, 2023

@jeffythedragonslayer No. Because when angle > 200, the rotation value is completely different for each frame. I let you imagine how it looks like when you run it in a rom.

@malayli
Copy link
Collaborator Author

malayli commented Mar 10, 2025

I close this issue as I have my own values for a complete rotation.

I also think that this issue was fixed in a recent version.

@malayli malayli closed this as completed Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants