Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use partykit functions for mmif? #40

Open
tdhock opened this issue Sep 5, 2019 · 1 comment
Open

use partykit functions for mmif? #40

tdhock opened this issue Sep 5, 2019 · 1 comment

Comments

@tdhock
Copy link
Collaborator

tdhock commented Sep 5, 2019

hey @parismita I noticed that you coded the mmif function "from scratch" and that is fine. But I was wondering if there was some simpler way to do it using functions provided by partykit. I asked Torsten:

tdhock> does partykit provide some helper functions to help automate / simplify fitting an
tdhock> ensemble?

there is some inftastructure (used by partykit::cforest or
trtf::traforest) but it is not as rich as the tree structure. At least you
can get node predictions and prediction weight without having to worry.
And there is some code for variable importances with user-defined loss
functions.

so it may be useful to look into how those functions are implemented if we want to change/simplify our implementation of random forests.

No need to do this right away but I thought I would mention that here, in case we ever want to.

@parismita
Copy link
Collaborator

yeah, I'll look into it...it would be cool to use some partykit or trtf function rather than coding from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants