Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discussion of atom mapping from original best practices #8

Open
fjclark opened this issue Dec 13, 2024 · 6 comments
Open

Update discussion of atom mapping from original best practices #8

fjclark opened this issue Dec 13, 2024 · 6 comments
Assignees

Comments

@fjclark
Copy link
Collaborator

fjclark commented Dec 13, 2024

Proposed Change

Update the atom mapping discussion moved here from the first paper (alchemistry/alchemical-best-practices#145).

Proposed Authors and Reviewers

Please volunteer (before the end of January) to author/ review and state when you're available. Authors, please say roughly when you plan to contribute the changes (no later than the end of May).

Proposed author: @RiesBen?
Proposed reviewer: Volunteer wanted

@hannahbruce
Copy link

I'm happy to review this section if needed

@fjclark fjclark removed the volunteers wanted Please volunteer to author or review label Jan 3, 2025
@RiesBen
Copy link

RiesBen commented Jan 3, 2025

on board, too! :)

@fjclark
Copy link
Collaborator Author

fjclark commented Jan 7, 2025

Brilliant, thanks!

@RiesBen
Copy link

RiesBen commented Feb 13, 2025

Hi @fjclark,
just saw, I never committed to a timeline :)
I think start of April would be cool, so @hannahbruce has also time to read it.
One question, is there some material on how to proceed with the update? Or shall I just go through the old parts and edit them?

Sorry because of my recent position change, my E-mails are a mess, and I might have missed something here.

Best

@fjclark
Copy link
Collaborator Author

fjclark commented Feb 13, 2025

Hi @RiesBen, great, thank you!

I've just forwarded the latest message with links to the Overleaf documents to the email on your website - please let me know if I should use a different address. The guidance isn't too specific - you can edit directly on the Overleaf documents, which have track-changes enabled (and then commit from there to GitHub), or fork and create a PR. We're generally recommending direct edits for small changes, and PRs for larger changes - but it's up to you. For this section, it would be great if you could move the original discussion from the first paper here (alchemistry/alchemical-best-practices#145 - I didn't get time to do this) and update it as you see fit.

Hope that makes sense, and let me know if you have any other questions.

Thanks.

@RiesBen
Copy link

RiesBen commented Feb 13, 2025

this is perfect! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants