Migrate to .net9 #40
Migrate to .net9 #40
Conversation
|
Thank you for your contrib! I'll review it in the next few days :) |
There was a problem hiding this comment.
First of all, thank you for your contrib. I think it's missing the publish-blazor.yml file (it has the reference to .NET 8).
Wrapping up:
- for the Blazor project I'd support both .NET 8 and .NET 9. The version of this package should be changed to 1.1.0
- for the Http project I'd support both .NET 8 and .NET 9. In this case this is a breaking change IMHO so the version should be changed to 2.0.0
| @@ -5,13 +5,13 @@ This repository contains a set of packages which allows you to add Google reCapt | |||
| ## KITT.Web.ReCaptcha.Blazor | |||
|
|
|||
| This project add Google reCaptcha to your Blazor apps.<br/> | |||
| This project targets **.NET 8** as supported Framework version. | |||
| This project targets **.NET 9** as supported Framework version. | |||
There was a problem hiding this comment.
I'm not sure to remove support for .NET 8 since it's the current LTS. Maybe better support both .NET 8 and .NET 9. What do you think?
| @@ -22,13 +22,13 @@ More informations are available on the project [README](https://github.com/albx/ | |||
| ## KITT.Web.ReCaptcha.Http | |||
|
|
|||
| This project add Google reCaptcha to your ASP.NET Core apps giving the service to validate your reCaptcha client response.<br/> | |||
| This project targets **.NET 6** and **.NET 8** as supported Framework versions. | |||
| This project targets **.NET 6** and **.NET 9** as supported Framework versions. | |||
There was a problem hiding this comment.
In this case maybe it's better keep .NET 8 and removing .NET 6, since it's not supported anymore. This will be a breaking change IMHO. What do you think?
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Razor"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <TargetFramework>net9.0</TargetFramework> | |||
There was a problem hiding this comment.
As told before. In this case I'd keep .NET 8 and add support to .NET 9
| @@ -1,26 +1,27 @@ | |||
| # KITT.Web.ReCaptcha.Blazor | |||
|
|
|||
| This project add Google reCaptcha to your Blazor apps.<br/> | |||
| This project targets **.NET 8** as supported Framework version. | |||
| This project targets **.NET 9** as supported Framework version. | |||
There was a problem hiding this comment.
As told before in the general readme. I'd support both .NET 8 and .NET 9
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net6.0;net8.0</TargetFrameworks> | |||
| <TargetFrameworks>net6.0;net9.0</TargetFrameworks> | |||
There was a problem hiding this comment.
As told before. I'd remove .NET 6 since it's not supported anymore and keep .NET 8, adding the support to .NET 9. This will be a breaking change
| @@ -1,24 +1,25 @@ | |||
| # KITT.Web.ReCaptcha.Http | |||
|
|
|||
| This project add Google reCaptcha to your ASP.NET Core apps giving the service to validate your reCaptcha client response.<br/> | |||
| This project targets **.NET 6** and **.NET 8** as supported Framework versions. | |||
| This project targets **.NET 6** and **.NET 9** as supported Framework versions. | |||
There was a problem hiding this comment.
As told before in the general readme. I'd remove .NET 6 and support both .NET 8 and .NET 9
All projects have been migrated to .net 9.