Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RE: JoSS Review] failing doctests #26

Closed
betteridiot opened this issue Nov 20, 2023 · 2 comments
Closed

[RE: JoSS Review] failing doctests #26

betteridiot opened this issue Nov 20, 2023 · 2 comments

Comments

@betteridiot
Copy link

betteridiot commented Nov 20, 2023

For the JoSS review at openjournals/joss-reviews/issues/6066

Please see https://github.com/betteridiot/joss_reviews/blob/master/cstag/joss_review.md for complete notes.

Doctests for cstag do not pass due to minor syntax errors. See Testing doctests. As doctests should also be testable (given their nature), this should be addressed.

@akikuno
Copy link
Owner

akikuno commented Nov 24, 2023

@betteridiot

I sincerely thank you for your comments regarding Doctests.

I have made modifications to ensure that the Doctests pass.
d37a56a

Additionally, I have added automatic testing for Doctests.
https://github.com/akikuno/cstag/actions/runs/6978602020/workflow#L39

I would be grateful if you could confirm them.

@betteridiot
Copy link
Author

This satisfies my request. Thank you @akikuno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants