Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RE: JoSS Review] CS tag deconfliction #25

Closed
betteridiot opened this issue Nov 20, 2023 · 2 comments
Closed

[RE: JoSS Review] CS tag deconfliction #25

betteridiot opened this issue Nov 20, 2023 · 2 comments

Comments

@betteridiot
Copy link

For the JoSS review at openjournals/joss-reviews/issues/6066.

The CS (uppercase) is a reserved for color read sequence information as per the SAM format, while the cs (lowercase)
tag represents the difference string. This has already been a topic of discussion while feature requests to incorporate the cs tag more
formally into the SAM format.

It might be beneficial to change the "CS" to "cs" in all documentation so as to not mislead users.

akikuno added a commit that referenced this issue Nov 23, 2023
@akikuno
Copy link
Owner

akikuno commented Nov 23, 2023

@betteridiot

Thank you very much for your invaluable review!

I have implemented the change to lowercase 'cs', as you pointed out, in both the paper and the GitHub documentation (README and Docstring).

JOSS Paper:

d7c6cfb

Document (README and Docstring):
20dec8d

I would appreciate your confirmation of these changes.

@betteridiot
Copy link
Author

This satisfies my suggestion. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants