diff --git a/alignunformeval/stsb.py b/alignunformeval/stsb.py index 7e130d0..53310b3 100644 --- a/alignunformeval/stsb.py +++ b/alignunformeval/stsb.py @@ -32,7 +32,26 @@ def __init__( if not os.path.exists(self.path_dev): self._download(self.URL, path=self.path_targz) with tarfile.open(self.path_targz, "r:*") as tar: - tar.extractall(str(self._get_cache_path())) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, str(self._get_cache_path())) df = pd.read_csv( self.path_dev, header=None,