New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cox model support not working #106

Open

deaneckles opened this issue Sep 3, 2018 · 0 comments

deaneckles commented Sep 3, 2018

It seems like model='cox' is not actually supported because predict.sgd doesn't know how to handle it, despite sgd accepting it.

sgd/R/predict.sgd.R

Lines 23 to 26 in a256063

    
           predict.sgd <- function(object, newdata, type="link", ...) { 
        
             if (!(object$model %in% c("lm", "glm", "m"))) { 
        
               stop("'model' not supported") 
        
             }

This then means that the example in https://github.com/airoldilab/sgd/blob/master/demo/cox-regression.R does not work.

Looking forward to trying this nice package with some continuous time data. Thanks!

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment