Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy should hold requests while building. #717

Open
brandonbloom opened this issue Dec 15, 2024 · 0 comments
Open

Proxy should hold requests while building. #717

brandonbloom opened this issue Dec 15, 2024 · 0 comments

Comments

@brandonbloom
Copy link

Presently, the retry loop is hard coded to 10 attempts with 100ms between attempts. Even without accounting for some of the configurable delays, builds can exceed 1 second. In that case, the attempt limit will always be exceeded.

Ideally, the proxy server should buffer requests while building, so that responses to clients are delayed until building finishes instead of being forced to retry. This would result in a better developer experience, since frequently the leaf of the retry tree is a human pressing refresh repeatedly in their browser. I'd rather hit refresh and wait a few seconds, than wait a few seconds while refreshing repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant