Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for digest authentication #4939

Open
beruhan opened this issue Aug 28, 2020 · 5 comments · May be fixed by #2213
Open

support for digest authentication #4939

beruhan opened this issue Aug 28, 2020 · 5 comments · May be fixed by #2213

Comments

@beruhan
Copy link

beruhan commented Aug 28, 2020

I used aiohttp for async http requests,but It dose not support digest authentication.I think it is a basic feature for http authentication, I found some one has done some effort to implement the goal, as follows #2213. can support this features officially?

@Shravan40
Copy link

I am really, looking forward to this feature.

@Maillol
Copy link
Contributor

Maillol commented Oct 3, 2020

I don't know if digest authentication must be a part of aiohttp or aiohttp-security
I have already used aiohttp-security to implement Basic Authentication.
https://github.com/Maillol/asterios/blob/master/asterios/authorization.py
I think it's possible to use aiohttp-security to implement digest authentication.

@webknjaz webknjaz linked a pull request Oct 3, 2020 that will close this issue
5 tasks
@kimjaemin95
Copy link

Hi, I use asyncio on python 3.9.0. and I need digest authentication of aiohttp. Does aiohttp support digest authentication?

@asvetlov
Copy link
Member

#2213 has good code chunks, that's why I did not remove it yet.
But it changes the client API.
Instead of async with client.get(url, auth=BasicAuth()) as resp ... the digest version should be used as


    auth = helpers.DigestAuth(digest_username, digest_password, client)

    try:
        resp = await auth.request('GET', '/')
         # handle response
    finally:
        resp.release()

I had a wish to refactor the auth code and allow writing third-party auth providers like OAuth.
Unfortunately, I had no time for this massive change yet.

@Pandede
Copy link

Pandede commented Oct 4, 2022

Is there any progress about this enhancement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants