Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor aiohttp-debugtoolbar to use new aiohttp sub application #71

Open
jettify opened this issue Nov 22, 2016 · 3 comments
Open

Refactor aiohttp-debugtoolbar to use new aiohttp sub application #71

jettify opened this issue Nov 22, 2016 · 3 comments

Comments

@jettify
Copy link
Member

jettify commented Nov 22, 2016

  • Create separate app for aiohttp-debugtoolbar
  • Hide all toolbar related URL behind this sub app

See also #65
@jettify jettify mentioned this issue Nov 22, 2016
Merged
@samuelcolvin samuelcolvin mentioned this issue Feb 25, 2017
Closed
@samuelcolvin
Copy link
Member

Any progress on this?

Currently aiohttp-debugtoolbar is more or less unusable with sub apps AFAIK. Or is there a workaround I'm missing?

Even if DBTB doesn't support sub-apps completely it shouldn't completely break when they are used, see aio-libs/aiohttp-devtools#39.

@jettify
Copy link
Member Author

jettify commented Feb 25, 2017 •
edited
Loading

Toolbar had been crated long before aiohttp introduced subapp feature, this improvement is more about proper code plug in, then functionality. I don not have any ETA for this, but PR is welcome

@Dreamsorcerer Dreamsorcerer mentioned this issue Sep 12, 2023
Closed
@Dreamsorcerer
Copy link
Member

Once this is done, we can also switch jinja templates to use static() for URLs (see #478).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jettify @Dreamsorcerer @samuelcolvin