-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe the react-scan should not be visible on production...only works on developement #83
Comments
Hi, can you elaborate on your issue? |
I don't think there's any plans to limit this on development as react-scan is useful for diagnosing problems in production as well. |
I don't understand. You want a production ready app that users are already using to have a dev tool on the UI causing nuisance? I've been trying to use git attributes and filters to remove the script tag from I don't want this to appear on production. Please give us an option to disable on production. |
Just use env for dev and prod to enable or disable the script tab in your html file. Wha is you environment, what do you use ... next, vite, webpack ... custom one? |
I use Vite, and can explain more about this env process. |
@onyedikachi23 yeah please :) |
Use option 1 with the vite plugin |
Sweet thank you! Any reason this plugin isn't a part of the million org? |
oh ... it is from yesterday :) sorry ... https://www.npmjs.com/package/@react-scan/vite-plugin-react-scan It's the same one ... I just made the first version in my org ;) |
I tried installing with command from the first link you dropped, and it wouldn't work. I've also tried out this new link, but same here results. Here are the details:
|
Hey @onyedikachi23 |
@pivanov Same issue as before. Please note I'm using the failed to load config from /[path]/vite.config.ts
error when starting dev server:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'cheerio' imported from /[path]/node_modules/@react-scan/vite-plugin-react-scan/dist/index.js
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:267:9)
at packageResolve (node:internal/modules/esm/resolve:768:81)
at moduleResolve (node:internal/modules/esm/resolve:854:18)
at defaultResolve (node:internal/modules/esm/resolve:984:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:688:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:612:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:595:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:248:38)
at ModuleJob._link (node:internal/modules/esm/module_job:136:49)
|
@pivanov I tried here and got a bunch of errors in my codebase that I have never encountered before while running Here are a few of the errors:
|
oh ... ok... it's fixed now try with latest version pls |
Thanks! That seemed to work. Everything looks good now, but I am seeing this in my console: EDIT: Furthermore, when I hot reload, these errors still show up in my terminal now, but they dont crash the app anymore. |
@charlieforward9 |
No description provided.
The text was updated successfully, but these errors were encountered: