Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render counts and highlights missing #68

Open
DanielSinclair opened this issue Dec 3, 2024 · 4 comments
Open

Render counts and highlights missing #68

DanielSinclair opened this issue Dec 3, 2024 · 4 comments

Comments

@DanielSinclair
Copy link

DanielSinclair commented Dec 3, 2024

I integrated react-scan into a webpack bundled Chrome extension using the scan() API, but oddly can't seem to get the render count and highlight-on-rerender to work as expected. The toolbar is visible, and the element selector and highlights are functional and capture the proper elements in the tree.

How should I go about diagnosing the issue?

Screencapture

Dec-03-2024.01-49-19.webm

Integration

import { scan } from 'react-scan';
import * as React from 'react';
/* ... */
if (process.env.IS_DEV === 'true') {
  scan({
    showToolbar: isFullScreen,
    report: true,
    log: true,
  });
}
@tbakerx
Copy link

tbakerx commented Dec 9, 2024

Your demo video appears to show that you've got them hidden in the toolbar (the eye icon with the line through).

@RobPruzan
Copy link
Collaborator

As @tbakerx mentioned, the eye ball with a cross means it's disabled. You can toggle it to enable it

@DanielSinclair
Copy link
Author

@RobPruzan To be clear, I am seeing this issue with the feature enabled. I was toggling it around for the demo video and must have left it disabled. Here is a better screen recording. Please re-open.
Dec-11-2024 15-41-02.webm

@RobPruzan RobPruzan reopened this Dec 16, 2024
@RobPruzan
Copy link
Collaborator

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants