Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crahes when target page immediately triggers a redirect #40

Open
levrik opened this issue Nov 26, 2024 · 5 comments
Open

Crahes when target page immediately triggers a redirect #40

levrik opened this issue Nov 26, 2024 · 5 comments

Comments

@levrik
Copy link

levrik commented Nov 26, 2024

Executing npx react-scan@latest against an URL which immediately triggers a redirect through JS crashes with the following error:

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

page.addScriptTag: Execution context was destroyed, most likely because of a navigation
    at /Users/levrik/.npm/_npx/bfc758176cdd0246/node_modules/react-scan/dist/cli.js:1:4086 {
  name: 'Error'
}

Sadly I cannot share the URL as it's internal and I couldn't find a public page which has the same issue.

@aidenybai
Copy link
Owner

@levrik fixed in latest

@levrik
Copy link
Author

levrik commented Nov 28, 2024

@aidenybai The issue still reproduces for me on [email protected].

@jakst
Copy link

jakst commented Nov 29, 2024

Same here. We've got auth kicking in and redirecting the user, which crashes react-scan. What I found though is that I can get around it by starting react scan without the URL, and then manually navigating to the app. I.e. just npx react-scan@latest.

@levrik
Copy link
Author

levrik commented Nov 29, 2024

@jakst Exact same situation for us. Auth kicking in and doing a redirect.

@lukeramsden
Copy link

Same here, redirecting to WorkOS and back for auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants