Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Theme support - feature request #1

Open
mariosant opened this issue Aug 25, 2019 · 7 comments
Open

Theme support - feature request #1

mariosant opened this issue Aug 25, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@mariosant
Copy link

Thank you for creating lucien!

Would you please consider support theming? The UI is great as it is now, but it might be a bit too whitey for a lot of people's tastes (I am one of those).

@mariosant mariosant changed the title Theme support request Theme support - feature request Aug 25, 2019
@agorf
Copy link
Owner

agorf commented Aug 25, 2019

Yep, that's actually a good idea. How about making it possible to load a custom CSS file?

Styling the textarea is trivial (background and text color) but styling the HTML area would take some effort I imagine.

@mariosant
Copy link
Author

A custom css file would be great, @agorf! Don't worry about the effort, the internet is full of themes which one could convert and use. I am happy to contribute a few, once you decide how to handle this.

@agorf
Copy link
Owner

agorf commented Aug 25, 2019

It would not be that easy. You'd have to copy and set the colors for this stylesheet: https://github.com/sindresorhus/github-markdown-css/blob/gh-pages/github-markdown.css

It has 59 color properties. 😰

@mariosant
Copy link
Author

Ouch! Maybe css variables can be of help there.

@agorf agorf added the enhancement New feature or request label Aug 25, 2019
@agorf
Copy link
Owner

agorf commented Aug 26, 2019

As Lucien currently does not use SASS/SCSS, this is not an option. Moreover, you'd still have to go to 59 points to extract them to variables.

This needs a bit of thought. I think one intermediate step would be to provide an option for a built-in dark theme with some sane colors (like many sites and Android apps to with "dark mode"). It will not be customizeable, but you'd at least have a dark option.

@mariosant
Copy link
Author

Sure, @agorf! Just to clarify, css variables are part of standard CSS. Check out https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

Having light or dark mode would be great as well!

@agorf
Copy link
Owner

agorf commented Aug 26, 2019

Cool, didn't know that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants