From 8aee73734388d72ac0ec8b0146f56e6bac4a66d9 Mon Sep 17 00:00:00 2001 From: oritwoen <18102267+oritwoen@users.noreply.github.com> Date: Fri, 14 Aug 2026 17:17:58 +0200 Subject: [PATCH] fix: deduplicate optional npm dependencies --- src/registries/npm.ts | 6 ++++++ test/unit/registries.test.ts | 1 + 2 files changed, 7 insertions(+) diff --git a/src/registries/npm.ts b/src/registries/npm.ts index 1074cf2..b7bb376 100644 --- a/src/registries/npm.ts +++ b/src/registries/npm.ts @@ -176,6 +176,12 @@ export class NpmRegistry extends Registry { // Runtime dependencies if (versionData.dependencies) { for (const [depName, requirements] of Object.entries(versionData.dependencies)) { + if ( + versionData.optionalDependencies && + Object.hasOwn(versionData.optionalDependencies, depName) + ) { + continue; + } dependencies.push({ name: depName, requirements, diff --git a/test/unit/registries.test.ts b/test/unit/registries.test.ts index c360e80..29220fe 100644 --- a/test/unit/registries.test.ts +++ b/test/unit/registries.test.ts @@ -194,6 +194,7 @@ describe("Registry Modules", () => { version: "4.17.21", dependencies: { underscore: "^1.0.0", + fsevents: "^2.3.0", }, devDependencies: { mocha: "^10.0.0",