Commit bfc5bb1
committed
fix: address PR #176 review (imran-siddique, carloshvp)
1. integration.yaml: category "Identity and access" -> "Identity & trust"
(schema enum fix); repository URL now points at the real,
publicly-reachable computeid-trace-adapter repo instead of a private
computeid-backend that 404s for readers.
2. convert-to-trace.js: references[] now uses the schema's actual shape
(rel/id/resolver/digest, schema/trace-claim.json's
additionalProperties: false rejects name/value). Emits a single
reference pointing at the evidence bundle by SHA-256 digest (hex,
per the digest pattern - an earlier attempt used base64url and would
still have failed schema validation). The record now carries a real
cnf.jwk and is genuinely Ed25519-signed (adapter-signing-key.pem /
adapter-signing-pubkey.pem), so TR-ENV-004 and both TR-SIG checks now
pass for real, not by fabricating a proof-of-possession claim about
the underlying passport itself - cnf here names the key that signs
this TRACE record, a separate concern from the AgentPassport's own
RSA + ML-DSA-65 identity keys, which remain in the referenced bundle.
3. offline-verifier.js: classical_signature_valid and
ml_dsa_signature_valid were reading the service's own
signature_valid/pq_signature_valid fields rather than independently
recomputing them - contradicting the file's own "independent
verification" claim. Both are now genuinely recomputed from raw
public_key/signature/signed_payload bytes in the bundle (RSA-SHA256
via node:crypto, ML-DSA-65 via @noble/post-quantum 0.4.1). Verified
adversarially: true against a genuine bundle, false against a
locally tampered payload.
4. CONFORMANCE.md: regenerated against a freshly registered ComputeID
passport (not the stale fixture, which was correctly failing
TR-ENV-002 on staleness rather than anything real), with the exact
command, tool version, and verbatim result recorded. Removed the
TR-APR-001 citation - no TR-APR module exists in trace-tests 0.5.1.
Real result: FAIL (7 checks, 1 failure - TR-POL-001 only, an honest
and permanent scope gap). Added the raw JSON Schema validation
result against schema/trace-claim.json @ 3a561d84 alongside it: 5
errors, down from 31, all five being the same disclosed fact
(model/policy/data_class/build_provenance/runtime.measurement do
not exist for an identity-only issuer) - none fabricated to force a
pass.
Added package.json/package-lock.json (previously missing from this
integration's directory - offline-verifier.js and convert-to-trace.js
both require dependencies that were never declared here) and
adapter-signing-pubkey.pem (the record-signing public key named in
cnf.jwk). The corresponding private key is intentionally not
committed (.gitignore'd, matching computeid-trace-adapter's own
pattern) and is held by the maintainer.1 parent bdc9ab7 commit bfc5bb1
10 files changed
Lines changed: 417 additions & 71 deletions
File tree
- integrations/computeid-agentpassport-trace
- evidence
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 67 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
10 | 14 | | |
11 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
12 | 19 | | |
13 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
14 | 66 | | |
15 | 67 | | |
16 | 68 | | |
17 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
18 | 74 | | |
19 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
20 | 78 | | |
21 | | - | |
| 79 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
11 | | - | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | | - | |
15 | | - | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | | - | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
Lines changed: 58 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
7 | 22 | | |
8 | 23 | | |
| 24 | + | |
9 | 25 | | |
10 | 26 | | |
11 | 27 | | |
| |||
14 | 30 | | |
15 | 31 | | |
16 | 32 | | |
17 | | - | |
18 | 33 | | |
19 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
20 | 45 | | |
21 | | - | |
| 46 | + | |
22 | 47 | | |
23 | 48 | | |
24 | 49 | | |
| |||
27 | 52 | | |
28 | 53 | | |
29 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
30 | 62 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
37 | 69 | | |
38 | 70 | | |
39 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
40 | 85 | | |
0 commit comments