feat: PAAL-123 move probe equality check to equality.go and reduce complexity

Author: qa-jil-kamerling

internal/controller/agent_controller.go

@@ -401,7 +401,8 @@ func (r *AgentReconciler) getOpenAIProtocol(agent *runtimev1alpha1.Agent) *runti
 }
 
 // getProtocolPort returns the port from protocol or default if not specified
-func (r *AgentReconciler) getProtocolPort(protocol *runtimev1alpha1.AgentProtocol, defaultPort int32) int32 {
+func (r *AgentReconciler) getProtocolPort(protocol *runtimev1alpha1.AgentProtocol) int32 {
+	defaultPort := int32(8000) // Default port if none specified
 	if protocol != nil && protocol.Port != 0 {
 		return protocol.Port
 	}
@@ -432,15 +433,15 @@ func (r *AgentReconciler) generateReadinessProbe(agent *runtimev1alpha1.Agent) *
 		// Use A2A agent card endpoint for health check
 		a2aProtocol := r.getA2AProtocol(agent)
 		healthPath := r.getA2AHealthPath(a2aProtocol)
-		port := r.getProtocolPort(a2aProtocol, 8000)
+		port := r.getProtocolPort(a2aProtocol)
 
 		probe := r.buildA2AReadinessProbe(healthPath, port)
 
 		return probe
 	} else if r.hasOpenAIProtocol(agent) {
 		// Use TCP probe for OpenAI-only agents
 		openaiProtocol := r.getOpenAIProtocol(agent)
-		port := r.getProtocolPort(openaiProtocol, 8000)
+		port := r.getProtocolPort(openaiProtocol)
 
 		probe := r.buildOpenAIReadinessProbe(port)
 

internal/controller/agent_controller_test.go

@@ -400,12 +400,12 @@ var _ = Describe("Agent Controller", func() {
 
 		It("should get protocol port with fallback to default", func() {
 			protocol := &runtimev1alpha1.AgentProtocol{Type: "A2A", Port: 9000}
-			port := reconciler.getProtocolPort(protocol, 8000)
+			port := reconciler.getProtocolPort(protocol)
 			Expect(port).To(Equal(int32(9000)))
 
 			// Test with zero port (should use default)
 			protocolNoPort := &runtimev1alpha1.AgentProtocol{Type: "A2A", Port: 0}
-			portDefault := reconciler.getProtocolPort(protocolNoPort, 8000)
+			portDefault := reconciler.getProtocolPort(protocolNoPort)
 			Expect(portDefault).To(Equal(int32(8000)))
 
 			// Test with nil protocol (should use default)