Implement review comments:

update path in samples
update controller test
remove unused sample
update CLAUDE.md
undo changes to e2e_test.go

Author: qa-jil-kamerling

CLAUDE.md

@@ -96,10 +96,9 @@ make docker-push
 │   ├── webhook/          # Webhook configurations
 │   └── samples/          # Example Agent resources
 ├── internal/
-│   ├── controller/       # Reconciliation logic and health check implementation
+│   ├── controller/       # Reconciliation logic
 │   └── webhook/          # Admission webhook handlers
-├── docs/
-│   └── examples/        # Health check implementation examples
+├── docs/                 # Documentation
 └── test/
     ├── e2e/             # End-to-end tests
     └── utils/           # Test utilities
@@ -165,14 +164,15 @@ spec:
 
 ## Health Check Architecture
 
-The operator implements **protocol-aware health checking** that automatically generates appropriate Kubernetes readiness probes based on agent protocol specifications:
+The operator implements **protocol-aware health checking** that automatically generates appropriate Kubernetes readiness 
+probes based on agent protocol specifications:
 
 ### Protocol-Based Health Checks
 
 **A2A Agents (Agent-to-Agent Protocol):**
 - **Probe Type**: HTTP GET request
 - **Endpoint**: `/a2a/.well-known/agent-card.json`
-- **Port**: 8000 (default)
+- **Port**: 8000 (or specified protocol port)
 - **Purpose**: Validates that A2A framework is initialized and agent skills are loaded
 - **Benefits**: Meaningful readiness signal that confirms agent functionality, not just HTTP server availability
 
@@ -195,18 +195,6 @@ The health check logic is implemented in `internal/controller/agent_controller.g
 - `hasOpenAIProtocol()`: Detects OpenAI protocol in agent specification
 - `probesEqual()`: Compares probe configurations to determine if deployment updates are needed
 
-### Migration from Legacy Health Endpoints
-
-**Previous Approach (Deprecated):**
-- Generic `/health` endpoints in each agent
-- Only validated HTTP server availability
-- Required manual implementation in every agent
-
-**Current Approach (Recommended):**
-- Operator-managed, protocol-aware health checking
-- Validates actual agent functionality for A2A agents
-- Zero health code required in agents
-- Centralized management and consistent behavior
 
 ## Configuration
 

config/samples/kustomization.yaml

@@ -3,7 +3,6 @@ resources:
 - runtime_v1alpha1_agent.yaml
 - runtime_v1alpha1_agent_template.yaml
 - runtime_v1alpha1_agent_openai.yaml
-- runtime_v1alpha1_agent_mixed.yaml
 - runtime_v1alpha1_agent_no_probe.yaml
 - configmap.yaml
 # +kubebuilder:scaffold:manifestskustomizesamples

config/samples/runtime_v1alpha1_agent.yaml

@@ -8,10 +8,13 @@ metadata:
 spec:
   framework: google-adk
   image: ghcr.io/agentic-layer/weather-agent:0.3.0
+  protocols:
+    - type: A2A
+      path: "/"
   replicas: 1
   env:
     - name: PORT
-      value: "8000"
+      value: "8080"
     - name: LOG_LEVEL
       value: "info"
   envFrom:

config/samples/runtime_v1alpha1_agent_mixed.yaml

@@ -9,7 +9,7 @@ spec:
   framework: google-adk
   description: "A news agent that fetches and summarizes current articles"
   instruction: "You are a news agent that can fetch current news articles and provide summaries. Use the news fetcher tool to get articles and the summarizer agent to create concise summaries."
-  model: "gemini/gemini-2.0-flash"
+  model: "gemini/gemini-2.5-flash"
   subAgents:
     - name: summarizer_agent
       url: "https://agents.example.com/summarizer-agent.json"
@@ -18,6 +18,9 @@ spec:
       url: "https://news.mcpservers.org/fetch/mcp"
     - name: web_fetch
       url: "https://remote.mcpservers.org/fetch/mcp"
+  protocols:
+    - type: A2A
+      path: "/"
   replicas: 1
   env:
     - name: LOG_LEVEL

config/samples/runtime_v1alpha1_agent_template.yaml

@@ -38,7 +38,8 @@ import (
 )
 
 const (
-	agentContainerName = "agent"
+	agentContainerName   = "agent"
+	a2aAgentCardEndpoint = "/.well-known/agent-card.json"
 )
 
 // AgentReconciler reconciles a Agent object
@@ -376,16 +377,63 @@ func (r *AgentReconciler) hasOpenAIProtocol(agent *runtimev1alpha1.Agent) bool {
 	return false
 }
 
+// getA2AProtocol returns the first A2A protocol configuration found
+func (r *AgentReconciler) getA2AProtocol(agent *runtimev1alpha1.Agent) *runtimev1alpha1.AgentProtocol {
+	for _, protocol := range agent.Spec.Protocols {
+		if protocol.Type == "A2A" {
+			return &protocol
+		}
+	}
+	return nil
+}
+
+// getOpenAIProtocol returns the first OpenAI protocol configuration found
+func (r *AgentReconciler) getOpenAIProtocol(agent *runtimev1alpha1.Agent) *runtimev1alpha1.AgentProtocol {
+	for _, protocol := range agent.Spec.Protocols {
+		if protocol.Type == "OpenAI" {
+			return &protocol
+		}
+	}
+	return nil
+}
+
+// getProtocolPort returns the port from protocol or default if not specified
+func (r *AgentReconciler) getProtocolPort(protocol *runtimev1alpha1.AgentProtocol, defaultPort int32) int32 {
+	if protocol != nil && protocol.Port != 0 {
+		return protocol.Port
+	}
+	return defaultPort
+}
+
+// getA2AHealthPath returns the A2A health check path based on protocol configuration
+func (r *AgentReconciler) getA2AHealthPath(protocol *runtimev1alpha1.AgentProtocol) string {
+	basePath := a2aAgentCardEndpoint
+	if protocol != nil && protocol.Path != "" {
+		// If path is explicitly specified, use it
+		// Special case: "/" means root path (no prefix)
+		if protocol.Path == "/" {
+			return basePath
+		}
+		return protocol.Path + basePath
+	}
+	// Default for agents without protocol specification or path
+	return "/a2a" + basePath
+}
+
 // generateReadinessProbe generates appropriate readiness probe based on agent protocols
 func (r *AgentReconciler) generateReadinessProbe(agent *runtimev1alpha1.Agent) *corev1.Probe {
 	// Priority: A2A > OpenAI > None
 	if r.hasA2AProtocol(agent) {
 		// Use A2A agent card endpoint for health check
+		a2aProtocol := r.getA2AProtocol(agent)
+		healthPath := r.getA2AHealthPath(a2aProtocol)
+		port := r.getProtocolPort(a2aProtocol, 8000)
+
 		return &corev1.Probe{
 			ProbeHandler: corev1.ProbeHandler{
 				HTTPGet: &corev1.HTTPGetAction{
-					Path: "/a2a/.well-known/agent-card.json",
-					Port: intstr.FromInt(8000),
+					Path: healthPath,
+					Port: intstr.FromInt(int(port)),
 				},
 			},
 			InitialDelaySeconds: 10,
@@ -396,10 +444,13 @@ func (r *AgentReconciler) generateReadinessProbe(agent *runtimev1alpha1.Agent) *
 		}
 	} else if r.hasOpenAIProtocol(agent) {
 		// Use TCP probe for OpenAI-only agents
+		openaiProtocol := r.getOpenAIProtocol(agent)
+		port := r.getProtocolPort(openaiProtocol, 8000)
+
 		return &corev1.Probe{
 			ProbeHandler: corev1.ProbeHandler{
 				TCPSocket: &corev1.TCPSocketAction{
-					Port: intstr.FromInt(8000),
+					Port: intstr.FromInt(int(port)),
 				},
 			},
 			InitialDelaySeconds: 10,
@@ -813,8 +864,8 @@ func (r *AgentReconciler) buildA2AAgentCardUrl(agent *runtimev1alpha1.Agent) str
 	// Find the A2A protocol
 	for _, protocol := range agent.Spec.Protocols {
 		if protocol.Type == "A2A" {
-			return fmt.Sprintf("http://%s.%s.svc.cluster.local:%d/.well-known/agent-card.json",
-				agent.Name, agent.Namespace, protocol.Port)
+			return fmt.Sprintf("http://%s.%s.svc.cluster.local:%d%s",
+				agent.Name, agent.Namespace, protocol.Port, a2aAgentCardEndpoint)
 		}
 	}
 	return ""