Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better tests #35

Open
2 tasks done
earlAchromatic opened this issue Apr 7, 2023 · 1 comment
Open
2 tasks done

Better tests #35

earlAchromatic opened this issue Apr 7, 2023 · 1 comment
Labels
infrastructure

Comments

@earlAchromatic
Copy link
Contributor

earlAchromatic commented Apr 7, 2023 •
edited
Loading

Some issues:

  • Tests require huge response objects that often go out of sync. Maintenance is hassle. there has got to be a better way.
    making the test tables much much smaller will help. We have tons of extraneous properties that are in the actual responses from Notion but aren't used or not needed to do a proper test.
  • Some tests just don't exist and if its not tested its not working.
@earlAchromatic earlAchromatic added the bug Something isn't working label Apr 7, 2023
@earlAchromatic earlAchromatic mentioned this issue Apr 9, 2023
Merged
@earlAchromatic earlAchromatic added infrastructure and removed bug Something isn't working labels Apr 10, 2023
@earlAchromatic
Copy link
Contributor Author

earlAchromatic commented Apr 10, 2023 •
edited
Loading

Leaving this open in order to track further improvements to tests. One such is full test coverage. Currently c8 shows about 80% coverage so should improve that.

  • typescript
  • achieve 100% test coverage.
  • refactor limiter test into the main test by using uvu before hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@earlAchromatic