Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to take div itemprop="articleBody" into account #61

Open
hecmec opened this issue Dec 5, 2016 · 0 comments
Open

try to take div itemprop="articleBody" into account #61

hecmec opened this issue Dec 5, 2016 · 0 comments

Comments

@hecmec
Copy link

hecmec commented Dec 5, 2016

Hello,
thanks for your module, it is working nicely.

I've had just a little issue with text extraction.
Your calculateBestNode() function doesn't take div or article into account and it will not check for schema.org itemprop="articleBody". But nodes marked with this itemprop are pretty good candidates.

Example:
http://www.lemonde.fr/election-presidentielle-2017/article/2016/12/02/et-hollande-renonca-a-se-representer_5042285_4854003.html
Your module extracts the parent.parent of the article and so takes the content-menu as text.

Thanks
Hector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant