fix(openapi): support 201 for create

The AEPs specify 201 is the correct response for a 
successful create request. OAS files which adhere to that
were missing their create methods.

Author: toumorokoshi

pkg/api/api.go

@@ -136,20 +136,22 @@ func GetAPI(api *openapi.OpenAPI, serverURL, pathPrefix string) (*API, error) {
 		} else {
 			// create method
 			if pathItem.Post != nil {
-				// check if there is a query parameter "id"
-				lroDetails = pathItem.Post.XAEPLongRunningOperation
-				if resp, ok := pathItem.Post.Responses["200"]; ok {
-					sRef = api.GetSchemaFromResponse(resp, openapi.APPLICATION_JSON)
-					supportsUserSettableCreate := false
-					for _, param := range pathItem.Post.Parameters {
-						if param.Name == "id" {
-							supportsUserSettableCreate = true
-							break
+				for _, statusCode := range []string{"200", "201"} {
+					// check if there is a query parameter "id"
+					if resp, ok := pathItem.Post.Responses[statusCode]; ok {
+						lroDetails = pathItem.Post.XAEPLongRunningOperation
+						sRef = api.GetSchemaFromResponse(resp, openapi.APPLICATION_JSON)
+						supportsUserSettableCreate := false
+						for _, param := range pathItem.Post.Parameters {
+							if param.Name == "id" {
+								supportsUserSettableCreate = true
+								break
+							}
+						}
+						r.Methods.Create = &CreateMethod{
+							SupportsUserSettableCreate: supportsUserSettableCreate,
+							IsLongRunning:              lroDetails != nil,
 						}
-					}
-					r.Methods.Create = &CreateMethod{
-						SupportsUserSettableCreate: supportsUserSettableCreate,
-						IsLongRunning:              lroDetails != nil,
 					}
 				}
 			}

pkg/api/api_test.go

@@ -414,6 +414,42 @@ func TestGetAPI(t *testing.T) {
 				assert.Equal(t, "https://example.com", sd.Contact.URL)
 			},
 		},
+		{
+			name: "resource with create returning 201",
+			api: &openapi.OpenAPI{
+				OpenAPI: "3.1.0",
+				Servers: []openapi.Server{{URL: "https://api.example.com"}},
+				Paths: map[string]*openapi.PathItem{
+					"/widgets": {
+						Post: &openapi.Operation{
+							Responses: map[string]openapi.Response{
+								"201": {
+									Content: map[string]openapi.MediaType{
+										"application/json": {
+											Schema: &openapi.Schema{
+												Ref: "#/components/schemas/Widget",
+											},
+										},
+									},
+								},
+							},
+						},
+					},
+				},
+				Components: openapi.Components{
+					Schemas: map[string]openapi.Schema{
+						"Widget": {
+							Type: "object",
+						},
+					},
+				},
+			},
+			validateResult: func(t *testing.T, sd *API) {
+				widget, ok := sd.Resources["widget"]
+				assert.True(t, ok, "widget resource should exist")
+				assert.NotNil(t, widget.Methods.Create, "should have CREATE method (from 201 response)")
+			},
+		},
 		{
 			name: "resource with long running operations",
 			api: &openapi.OpenAPI{