unit_tests.AddressFromURL.Failure: fixed seemingly wrong assertion

stoffu · stoffu · commit 17568c0958a7 · 2022-12-20T15:43:53.000+09:00
diff --git a/tests/unit_tests/address_from_url.cpp b/tests/unit_tests/address_from_url.cpp
@@ -114,7 +114,7 @@ TEST(AddressFromURL, Failure)
   std::vector<std::string> addresses = tools::dns_utils::addresses_from_url("example.veryinvalid", dnssec_result);
 
   // for a non-existing domain such as "example.invalid", the non-existence is proved with NSEC records
-  ASSERT_TRUE(dnssec_result);
+  ASSERT_FALSE(dnssec_result);
 
   ASSERT_EQ(0, addresses.size());
 }

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ TEST(AddressFromURL, Failure)`
`114`	`114`	`std::vector<std::string> addresses = tools::dns_utils::addresses_from_url("example.veryinvalid", dnssec_result);`
`115`	`115`
`116`	`116`	`// for a non-existing domain such as "example.invalid", the non-existence is proved with NSEC records`
`117`		`- ASSERT_TRUE(dnssec_result);`
	`117`	`+ ASSERT_FALSE(dnssec_result);`
`118`	`118`
`119`	`119`	`ASSERT_EQ(0, addresses.size());`
`120`	`120`	`}`