From 858f743d9a1319a1b05a1aaa36bc4d8c9382e694 Mon Sep 17 00:00:00 2001 From: John Grimes Date: Wed, 26 Jun 2024 10:43:05 +1000 Subject: [PATCH 1/2] Fix incorrect expectations on getReferenceKey without and right type specifier These should be false, as `link.other.getReferenceKey()` should return a key for `Patient/p3`. The absence of the type specifier should not cause this to return an empty collection, rather the collection should be unconstrained by the type of the reference. In the case where it is the right type specifier, it should also return a non-empty collection. --- tests/fn_reference_keys.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fn_reference_keys.json b/tests/fn_reference_keys.json index ed03d35..157c2d4 100644 --- a/tests/fn_reference_keys.json +++ b/tests/fn_reference_keys.json @@ -48,7 +48,7 @@ "key_equal_ref": true }, { - "key_equal_ref": null + "key_equal_ref": false } ] }, @@ -73,7 +73,7 @@ "key_equal_ref": true }, { - "key_equal_ref": null + "key_equal_ref": false } ] }, From c60eac59d9d21d8535022f6e24b664e0d0dedf56 Mon Sep 17 00:00:00 2001 From: John Grimes Date: Wed, 26 Jun 2024 13:28:51 +1000 Subject: [PATCH 2/2] Remove implementation-specific field from reference key test The inclusion of the direct result of the getReferenceKey call in the test makes it implementation-specific and moves outside of the scope of the specification. --- tests/fn_reference_keys.json | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/fn_reference_keys.json b/tests/fn_reference_keys.json index 157c2d4..30844c1 100644 --- a/tests/fn_reference_keys.json +++ b/tests/fn_reference_keys.json @@ -84,11 +84,6 @@ "select": [ { "column": [ - { - "path": "link.other.getReferenceKey(Observation)", - "name": "referenceKey", - "type": "string" - }, { "path": "getResourceKey() = link.other.getReferenceKey(Observation)", "name": "key_equal_ref", @@ -100,11 +95,9 @@ }, "expect": [ { - "referenceKey": null, "key_equal_ref": null }, { - "referenceKey": null, "key_equal_ref": null } ]