Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query block #30

Open
hchw opened this issue May 7, 2019 · 4 comments
Open

query block #30

hchw opened this issue May 7, 2019 · 4 comments

Comments

@hchw
Copy link

hchw commented May 7, 2019

i found query would blocking, when one slot or node crash ,
because you refresh slots map synchronous
how about let refresh asynchronous and let query return fail immediately?

@hchw
Copy link
Author

hchw commented May 7, 2019

i try to make refresh be a event , and deal it in a event process, and cast the result to monitor. do you have some advice for me?Or do you agree with me?
i will make PR when it stable

@clanchun
Copy link

clanchun commented May 7, 2019

i found query would blocking, when one slot or node crash ,
because you refresh slots map synchronous
how about let refresh asynchronous and let query return fail immediately?

hello, that's exactly what I'm doing in our use case, also I found the retry https://github.com/adrienmo/eredis_cluster/blob/master/src/eredis_cluster.erl#L178 may be too many, I set it to 2.

@hchw
Copy link
Author

hchw commented May 8, 2019

thank you for your reply. i try to make refresh be a event , cast the event to a new event process to deal the refresh map, and send the result to monitor's state. how about this idea?

@clanchun
Copy link

clanchun commented May 8, 2019

thank you for your reply. i try to make refresh be a event , cast the event to a new event process to deal the refresh map, and send the result to monitor's state. how about this idea?

almost the same with my modification, just to be clear, I'm not the maintainer of this repo, I just modified it a bit and is still testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants