Skip to content

Commit 4e06533

Browse files
committed
fix(button): upgrade latest css
1 parent 6c58f50 commit 4e06533

File tree

9 files changed

+648
-638
lines changed

9 files changed

+648
-638
lines changed

.changeset/curvy-boxes-poke.md

+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
'@spectrum-web-components/button': patch
3+
'@spectrum-web-components/styles': patch
4+
---
5+
6+
This update aims to simplify `--mod-*` access by ensuring local variants and states aren't hooking into those custom properties for overrides. This updates all local variants and states to override the `--spectrum-button-*` properties instead and adjusts the specificity to ensure no regressions in rendered results.
7+
8+
From [@spectrum-css/button v14.1.3](https://www.npmjs.com/package/@spectrum-css/button/v/14.1.3): [#3613](https://github.com/adobe/spectrum-css/pull/3613) Thanks [@​rise-erpelding](https://github.com/rise-erpelding)!
9+
10+
Adjusts static color buttons to more closely resemble the S2 specifications. There are no expected changes to non-static button variants in S2, and no expected changes to other themes.
11+
12+
This PR includes changes to:
13+
14+
- Static white primary button (outline variant), static white secondary button (fill variant), static black primary button (outline variant), static black secondary button (fill variant)
15+
- Static white secondary button (outline variant) and static black secondary button (outline variant) border and background colors
16+
- Static color buttons' content color
17+
- Static white primary button (fill variant) and static black primary button (fill variant) background colors
18+
19+
From [@spectrum-css/button v14.1.2](https://www.npmjs.com/package/@spectrum-css/button/v/14.1.2): [#​3600](https://github.com/adobe/spectrum-css/pull/3600) Thanks [@​rise-erpelding](https://github.com/rise-erpelding)!
20+
21+
Adjust border colors for static black and static white outline buttons, primary variant to match S2 specifications.

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ parameters:
1414
# 3. Commit this change to the PR branch where the changes exist.
1515
current_golden_images_hash:
1616
type: string
17-
default: f0b3f3b4daf8fe12a6f13ff2e3b84dab31c76091
17+
default: 8f3ecb2c63d401eeb80e88e9f1eefa38f271734c
1818
wireit_cache_name:
1919
type: string
2020
default: wireit

packages/button/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"@spectrum-web-components/shared": "1.4.0"
100100
},
101101
"devDependencies": {
102-
"@spectrum-css/button": "14.1.1"
102+
"@spectrum-css/button": "14.1.6"
103103
},
104104
"types": "./src/index.d.ts",
105105
"customElements": "custom-elements.json",

0 commit comments

Comments
 (0)