Skip to content

Commit 5358f5a

Browse files
authored
feat(storybook): documentation migration (#3125)
* feat(storybook): documentation migration * chore: remove all yml processing and files
1 parent 1f5e60c commit 5358f5a

File tree

182 files changed

+108
-32425
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+108
-32425
lines changed

.env.example

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ NX_INTERACTIVE=true
1111

1212
# Default dev environment settings
1313
NODE_ENV=development
14-
STORYBOOK_URL="/preview/"
1514
WATCH_MODE=true
1615

1716
# Optional NX settings

.eslintignore

-1
This file was deleted.

.github/CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ To kick-off the project's storybook locally, run:
8181
yarn start
8282
```
8383

84-
This is our development environment, where you can see all the components in action, and develop new components. All components must have a storybook entry. Edits to any of the `*.css`, `*.stories.js`, or `template.js` files in `components/*` will live reload in your browser. For more details about how to work within our Storybook setup, take a look at our [getting started Storybook guide](https://opensource.adobe.com/spectrum-css/preview/?path=/docs/guides-contributing--docs).
84+
This is our development environment, where you can see all the components in action, and develop new components. All components must have a storybook entry. Edits to any of the `*.css`, `*.stories.js`, or `template.js` files in `components/*` will live reload in your browser. For more details about how to work within our Storybook setup, take a look at our [getting started Storybook guide](https://opensource.adobe.com/spectrum-css/?path=/docs/guides-contributing--docs).
8585

8686
This project is leveraging caching from [Nx](https://nx.dev/) to speed up the build process. If you are seeing unexpected results, you can clear the cache by running `yarn nx reset`.
8787

.github/GUIDE.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ _to-do_: This needs to diff the actual content of the files as well. Right now w
6565
6666
Runs stylelint or eslint if any relevant assets have been updated in this PR.
6767
68-
##### 📝 Publish site
68+
##### 📝 Publish documentation site
6969
70-
After the build and visual regression tests have passed, this will build the docs site and publish it to Netlify.
70+
After the build and visual regression tests have passed, this will build the documentation site and publish it to Netlify.
7171
7272
##### 📸 Visual regression testing
7373
@@ -93,7 +93,7 @@ Builds the `main` branch and outputs the compiled assets as artifacts.
9393
9494
##### 📝 2. Publish site
9595
96-
Publish the docs site to Netlify.
96+
Publish the documentation site to Netlify.
9797
9898
##### 📸 3. Visual regression testing
9999

.github/workflows/development.yml

-6
Original file line numberDiff line numberDiff line change
@@ -189,14 +189,8 @@ jobs:
189189
# -------------------------------------------------------------
190190
publish_site:
191191
name: Publish
192-
# The build step ensures we are leveraging the cache for the build
193-
needs: [vrt]
194-
# Note: the goal here is to allow vrt to be skipped but still require the build to succeed
195-
if: ${{ always() }}
196192
uses: ./.github/workflows/publish-site.yml
197193
with:
198194
deploy-message: ${{ github.event.pull_request.title }}
199195
alias: pr-${{ github.event.number }}
200-
# Only pass the storybook url if the vrt was successful
201-
storybook-url: ${{ needs.vrt.outputs.storybook-url || '' }}
202196
secrets: inherit

.github/workflows/production.yml

-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ name: Build and verify production
77
# - Publish the PR branch to Netlify
88
# -------------------------------------------------------------
99

10-
1110
on:
1211
push:
1312
branches: [main, spectrum-two]
@@ -62,11 +61,7 @@ jobs:
6261
# -------------------------------------------------------------
6362
publish_site:
6463
name: Publish
65-
# The build step ensures we are leveraging the cache for the build
66-
needs: [vrt]
6764
uses: ./.github/workflows/publish-site.yml
68-
with:
69-
storybook-url: ${{ needs.vrt.outputs.storybook-url || '' }}
7065
secrets: inherit
7166

7267
todo_to_issue:

.github/workflows/publish-site.yml

+2-18
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ on:
1212
alias:
1313
required: false
1414
type: string
15-
storybook-url:
16-
required: false
17-
type: string
18-
default: ''
1915
workflow_call:
2016
inputs:
2117
deploy-message:
@@ -24,10 +20,6 @@ on:
2420
alias:
2521
required: false
2622
type: string
27-
storybook-url:
28-
required: false
29-
type: string
30-
default: ''
3123

3224
permissions:
3325
contents: read
@@ -75,22 +67,14 @@ jobs:
7567
run: yarn install --immutable
7668

7769
## --- BUILD --- ##
78-
- name: Build docs site
79-
shell: bash
80-
run: yarn build:site
81-
env:
82-
CHROMATIC_URL: ${{ inputs.storybook-url }}
83-
84-
- name: Build storybook site
85-
if: ${{ ! inputs.storybook-url }}
70+
- name: Build storybook
8671
shell: bash
87-
run: yarn nx run storybook:build:docs
72+
run: yarn build:docs
8873

8974
## --- DEPLOY WEBSITE TO NETLIFY --- ##
9075
- name: Deploy
9176
uses: nwtgck/actions-netlify@v3
9277
with:
93-
# publish-dir: site/dist
9478
publish-dir: dist
9579
production-branch: main
9680
production-deploy: false

.github/workflows/vrt.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
exitOnceUploaded: true
7474
onlyChanged: true
7575
traceChanged: true
76-
untraced: ".github/actions/*/package.json site/package.json generator/package.json"
76+
untraced: ".github/actions/*/package.json generator/package.json"
7777
diagnostics: true
7878
autoAcceptChanges: "main"
7979
# Lets VRT pass without running so as not to waste snapshots

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
dist
2-
dist-site
32
!tokens/dist/index.css
43
!tokens/dist/css/*.css
54
!tokens/dist/css/express/*.css

.prettierignore

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
**/.hg
55
**/node_modules
66

7-
# Static utility assets
8-
site/includes/*.js
9-
107
# Compiled and generated files
118
dist
129
.storybook/storybook-static

.storybook/deprecated/cyclebutton/cyclebutton.yml

-15
This file was deleted.

.storybook/deprecated/quickaction/quickaction.yml

-47
This file was deleted.

.storybook/deprecated/searchwithin/searchwithin.yml

-104
This file was deleted.

.storybook/deprecated/splitbutton/splitbutton.yml

-76
This file was deleted.

0 commit comments

Comments
 (0)