chore: harden recently updated scripts (#3680)

Author: castastrophe

.github/workflows/development.yml

@@ -137,6 +137,8 @@ jobs:
             styles_modified_files: ${{ needs.changed_files.outputs.styles_modified_files }}
             eslint_added_files: ${{ needs.changed_files.outputs.eslint_added_files }}
             eslint_modified_files: ${{ needs.changed_files.outputs.eslint_modified_files }}
+            mdlint_added_files: ${{ needs.changed_files.outputs.mdlint_added_files }}
+            mdlint_modified_files: ${{ needs.changed_files.outputs.mdlint_modified_files }}
         secrets: inherit
 
     # -------------------------------------------------------------

.storybook/assets/base.css

@@ -29,16 +29,31 @@ body {
 }
 
 .spectrum {
+	/* Gradient that changes with the color theme. */
+	--spectrum-examples-gradient: linear-gradient(45deg, var(--spectrum-magenta-1500), var(--spectrum-blue-1500));
+
+	/* Gradients that do not change with the color theme, for use in static color backgrounds. */
+	--spectrum-examples-gradient-static-black: linear-gradient(45deg, rgb(255 241 246), rgb(238 245 255));
+	--spectrum-examples-gradient-static-white: linear-gradient(45deg, rgb(64 0 22), rgb(14 24 67));
+
 	color: var(--spectrum-neutral-content-color-default);
 	background-color: var(--spectrum-background-base-color);
-	-webkit-tap-highlight-color: rgba(0, 0, 0, 0%);
+	-webkit-tap-highlight-color: rgb(0, 0, 0, 0%);
 }
 
 .spectrum.spectrum--legacy {
 	color: var(--spectrum-neutral-content-color-default);
 	background-color: var(--spectrum-background-layer-1-color);
 }
 
+.spectrum .spectrum-examples-static-black {
+	background: var(--spectrum-examples-gradient-static-black);
+}
+
+.spectrum .spectrum-examples-static-white {
+	background: var(--spectrum-examples-gradient-static-white);
+}
+
 /* Hide the SVG elements that only include references */
 svg:has(symbol):not(:has(use)) {
 	display: none;
@@ -58,7 +73,7 @@ svg:has(symbol):not(:has(use)) {
 	line-height: normal;
 	letter-spacing: normal;
 	text-transform: none;
-	border-block-end: 1px solid hsla(203deg, 50%, 30%, 15%);
+	border-block-end: 1px solid hsl(203deg, 50%, 30%, 15%);
 }
 
 /* Force the modal wrapper to be contained by the frame not the viewport */

tasks/clean-up-after-migration.sh

@@ -13,11 +13,6 @@
 # After migrating from our old build system, there are a lot of empty folders hanging out still
 # This script aims to clean up those folders
 
-# Legacy tools folder (included storybook & generator)
-# test -d "tools" && rm -rf tools
-
-test -d "tools" && rm -rf tools
-
 # Remove deprecated files
 for folder in components/*; do
     # Only processing nested folders, not top-level files

tokens/utilities/data-json-formatter.js

@@ -9,7 +9,7 @@ export const format = ({ dictionary, platform, file, options }) => {
 	);
 
 	const convertRef = (ref) => {
-		return ref.replace(/\{(.*?)\}/g, `var(--${prefix}-$1)`);
+		return ref?.toString()?.replace(/\{(.*?)\}/g, `var(--${prefix}-$1)`);
 	};
 
 	const deconstructSets = (obj, scope = undefined) => {
@@ -23,11 +23,11 @@ export const format = ({ dictionary, platform, file, options }) => {
 			if (data.ref) {
 				data.ref = convertRef(data.ref);
 
-				if (data.ref === data.value) {
+				if (data.ref?.toString() === data.value?.toString()) {
 					delete data.ref;
 				}
 			}
-			
+
 			if (data.sets) {
 				data = deconstructSets(data, context);