fix: React 19 strict mode drag and drop bug #8562
Merged
+35
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Jul 16, 2025
| @@ -240,9 +241,11 @@ export function useDrag(options: DragOptions): DragResult { | |||
| // If the dragged element is removed from the DOM via onDrop, onDragEnd won't fire: https://bugzilla.mozilla.org/show_bug.cgi?id=460801 | |||
| // In this case, we need to manually call onDragEnd on cleanup | |||
|
|
|||
| useLayoutEffect(() => { | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
Switched to useEffect because layout effect cleanups happen before the element is actually removed.
snowystinger
previously approved these changes
Jul 16, 2025
|
looks like a react 16 test is failing though |
|
Build successful! 🎉 |
reidbarber
approved these changes
Jul 17, 2025
LFDanLu
approved these changes
Jul 17, 2025
yihuiliao
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8548
Due to facebook/react#29585, React sometimes triggers extra effect cleanups when elements are reordered. This can occur during virtualized scrolling. When keyboard dragging and scrolling the dragged element out of view, the drop target would unexpectedly shift to another target. The layout effect caused the drag to be aborted and the global state to reset, resulting in our
isInternalchecks failing.This stores the actual dragged element in a ref instead of just a boolean. Then in the effect cleanup we check if the element has actually unmounted from the DOM. This will ignore false positives caused by strict mode where React calls the cleanup function even when not actually unmounting.