Skip to content

Combobox does not close on ModalOverlay click when menuTrigger=focus #10074

Description

@piyushsarkar

Provide a general summary of the issue here

When combobox menuTrigger is set to focus, clicking the ModalOverlay does not close an open combobox.

<ComboBox menuTrigger="focus">
  <ComboBoxItem>Item 1</ComboBoxItem>
  <ComboBoxItem>Item 2</ComboBoxItem>
</ComboBox>

This was working correctly in react-aria-components version 1.16.0, but after upgrading to 1.17.0, clicking the modal overlay no longer closes the combobox popover.

The issue seems specific to menuTrigger="focus" since menuTrigger="input" and menuTrigger="manual" still working correctly.

🤔 Expected Behavior?

The combobox popover should close when the modal overlay is clicked.

😯 Current Behavior

The combobox popover remains open after clicking the modal overlay.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://stackblitz.com/edit/c3rm1h73-dyetugob?file=src%2FExample.tsx

Version

react-aria-components@1.17.0

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

macos 26.4.1

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions