Replies: 1 comment 3 replies
-
Thanks for the write up. What version of Storybook are you using? Also, are you using auto action generation based on the types? |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I’m writing this post to share our findings and the paths we are pursuing to solve a set of issues that appeared after updating our project’s react-aria-components dependency to version 1.11.0+. While we are not certain of the exact commit, all of our issues began when we updated from version 1.10.1 to 1.11.0. We’ve found the root cause to be the intersection of our component patterns and the changes introduced in React Aria Components, which we suspect is related to PR #8327 “Pass through more DOM events and attributes”.
We’ve observed the following critical issues:
<Dialog>
, as it automatically wraps itself in a Modal. As a result, our Dialog component needs access to both modal and dialog props.Paths We Are Pursuing
Based on our investigation, we are pursuing a few different paths to solve these issues. We have had some success with these so far.
For Storybook Performance
We found that directly passing args from Storybook’s controls to the component was the cause of the performance issue. We discovered a pattern that avoids this problem:
This is exactly what our TileGroup component story was doing, which is why it worked without issue while others did not. The performance regression in RAC 1.11.0+ appears to be triggered specifically by the args spreading pattern, likely due to PR #8327’s DOM event passthrough changes.
For TypeScript Conflicts:
Final Outcome (so far)
With these changes, our build now completes without TypeScript errors, and our components that we have worked on so far are performant and smooth in Storybook. The issues we encountered were not with the components themselves but with how they interacted with the Storybook environment and our existing code patterns in the new version of React Aria Components.
We hope this information is helpful to others who may encounter similar issues when migrating to react-aria-components 1.11.0+.
Beta Was this translation helpful? Give feedback.
All reactions