Skip to content

Commit 64acead

Browse files
authored
Fix Incorrect file name from Download component DownloadServlet.java (#2903)
Fixes #2751
1 parent d8834a1 commit 64acead

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/servlets/DownloadServlet.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ private void sendResponse(InputStream stream, long size, String mimeType, String
191191
response.setContentLength((int) size);
192192
}
193193
if (inline) {
194-
response.setHeader(CONTENT_DISPOSITION_HEADER, "inline");
194+
response.setHeader(CONTENT_DISPOSITION_HEADER, "inline; filename=\"" + filename + "\"");
195195
response.setHeader(CSP_HEADER, "sandbox");
196196
} else {
197197
response.setHeader(CONTENT_DISPOSITION_HEADER, "attachment; filename=\"" + filename + "\"");

bundles/core/src/test/java/com/adobe/cq/wcm/core/components/internal/servlets/DownloadServletTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void testInlineAssetDownload() throws Exception {
8585
context.requestPathInfo().setExtension("pdf");
8686
downloadServlet.doGet(context.request(), context.response());
8787
assertTrue(context.response().containsHeader("Content-Disposition"));
88-
assertEquals("inline", context.response().getHeader("Content-Disposition"));
88+
assertEquals("inline; filename=\"Download_Test_PDF.pdf\"", context.response().getHeader("Content-Disposition"));
8989
assertTrue(context.response().containsHeader("Content-Security-Policy"));
9090
assertEquals("sandbox", context.response().getHeader("Content-Security-Policy"));
9191
assertEquals(8192, context.response().getBufferSize());

0 commit comments

Comments
 (0)