Validate for AASd-117 and AASd-120

[sebbader-sap]

What?

The named constraints do not appear in the JSON Schema or Part 1 OpenAPI file:

Constraint AASd-117: idShort of non-identifiable Referables not being a direct child of a SubmodelElementList shall be specified.

Constraint AASd-120: idShort of submodel elements being a direct child of a SubmodelElementList shall not be specified.

How?

For instance by changing the OpenAPI declaration to:

SubmodelElementCollection: 
  allOf: 
  - $ref: '#/components/schemas/AbstractSubmodelElement'
  - properties: 
       modelType: 
           type: string 
           pattern: ^SubmodelElementCollection$ 
      value: 
         type: array 
         items: 
             allOf: 
             - $ref: '#/components/schemas/SubmodelElement' 
             - required: 
                  - idShort
          minItems: 1 
SubmodelElementList: 
    allOf: 
    - $ref: '#/components/schemas/AbstractSubmodelElement' 
    - properties: 
          modelType: 
              type: string 
              pattern: ^SubmodelElementList$ 
          orderRelevant: 
               type: boolean 
         value: 
               type: array 
               items: 
                  allOf: 
                   - $ref: '#/components/schemas/SubmodelElement' 
                   - not: 
                        required: 
                        - idShort 
               minItems: 1 
         semanticIdListElement: 
             $ref: '#/components/schemas/Reference' 
         typeValueListElement: 
             $ref: '#/components/schemas/AasSubmodelElements' 
         valueTypeListElement: 
              $ref: '#/components/schemas/DataTypeDefXsd' 
         required: - typeValueListElement

[sebbader-sap]

Todo: transfer to aas-specs and notify Sebastian Heppner.

[BirgitBoss]

This issue has its source in aas-core-meta, see issue aas-core-works/aas-core-meta#294

[mristin]

@sebbader-sap this is not a aas-core-meta issue, as the invariants are appropriately specified. However, when we transpile from aas-core-meta to JSON schema, we leave out interpretation of many invariants, including AASd-120 and AASd-117.

So far, I only considered patterns and length restrictions. Theoretically, we could have a look at how transpilation of AASd-120 and AASd-117 can be achieved such that we can handle such cases in general.

[mristin]

@sebbader-sap there is no straightforward way to transpile the constraints as complex as this one automatically from Python code to JSON schema.

This would be an interesting topic for a semester thesis or part of an internship, though!

In the meanwhile, you can patch the schema manually. Later @s-heppner and I should be able to come up with semantic patching.