Fix error with pathname (#978)

* test: update web platform tests

* update consume_prepared_path and parse_prepared_path, if it's a double dot path segment, ignore if it's shorten path or special

* update tests to align with last changes

---------

Co-authored-by: anonrig <[email protected]>

Author: CarlosEduR

src/helpers.cpp

@@ -779,8 +779,8 @@ ada_really_inline void parse_prepared_path(std::string_view input,
               ? path_buffer_tmp
               : path_view;
       if (unicode::is_double_dot_path_segment(path_buffer)) {
-        if ((helpers::shorten_path(path, type) || special) &&
-            location == std::string_view::npos) {
+        helpers::shorten_path(path, type);
+        if (location == std::string_view::npos) {
           path += '/';
         }
       } else if (unicode::is_single_dot_path_segment(path_buffer) &&

src/url_aggregator.cpp

@@ -1563,8 +1563,8 @@ inline void url_aggregator::consume_prepared_path(std::string_view input) {
               ? path_buffer_tmp
               : path_view;
       if (unicode::is_double_dot_path_segment(path_buffer)) {
-        if ((helpers::shorten_path(path, type) || special) &&
-            location == std::string_view::npos) {
+        helpers::shorten_path(path, type);
+        if (location == std::string_view::npos) {
           path += '/';
         }
       } else if (unicode::is_single_dot_path_segment(path_buffer) &&

tests/basic_tests.cpp

@@ -375,8 +375,8 @@ TYPED_TEST(basic_tests, node_issue_47889) {
   auto url = ada::parse<TypeParam>("..#", &*urlbase);
   ASSERT_TRUE(url);
   ASSERT_TRUE(url->has_opaque_path);
-  ASSERT_EQ(url->get_href(), "a:b#");
-  ASSERT_EQ(url->get_pathname(), "b");
+  ASSERT_EQ(url->get_href(), "a:b/#");
+  ASSERT_EQ(url->get_pathname(), "b/");
   SUCCEED();
 }
 

tests/wpt/ada_extra_urltestdata.json

@@ -274,15 +274,15 @@
   {
     "input": "..#",
     "base": "a:b",
-    "href": "a:b#",
+    "href": "a:b/#",
     "origin": null,
     "protocol": "a:",
     "username": "",
     "password": "",
     "host": "",
     "hostname": "",
     "port": "",
-    "pathname": "b",
+    "pathname": "b/",
     "search": "",
     "hash": ""
   }

tests/wpt/setters_tests.json

@@ -2214,6 +2214,14 @@
                 "href": "http://example.net/%00",
                 "pathname": "/%00"
             }
+        },
+        {
+            "href": "foo://path/to",
+            "new_value": "/..",
+            "expected": {
+                "href": "foo://path/",
+                "pathname": "/"
+            }
         }
     ],
     "search": [