-
Notifications
You must be signed in to change notification settings - Fork 17
React-ChatLog Supriya #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
121ff15
e1f981f
2d91f5b
93a846c
4678c46
c307544
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,51 @@ | ||
| import React from 'react'; | ||
| import './App.css'; | ||
| import ChatLog from './components/ChatLog'; | ||
| import chatMessages from './data/messages.json'; | ||
| import { useState } from 'react'; | ||
|
|
||
| let numberOfLikes = 0; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the liked status of a message lives in the // This could be returned from a helper function
// totalLikes is a variable that accumulates a value as we loop over each entry in chatEntries
const likesCount = MessageData.reduce((totalLikes, currentMessage) => {
// If currentMessage.liked is true add 1 to totalLikes, else add 0
return (totalLikes += currentMessage.liked ? 1 : 0);
}, 0); // The 0 here sets the initial value of totalLikes to 0 |
||
| const App = () => { | ||
| const [MessageData, setMessageData] = useState(chatMessages) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Javascript naming best practices uses camel case for local variables, I recommend |
||
|
|
||
| const updateMessageData = updatedChatEntry =>{ | ||
| const entries = MessageData.map((chat) => { | ||
| if(chat.id === updatedChatEntry.id){ | ||
| numberOfLikes = updatedChatEntry.liked ? numberOfLikes+1 : numberOfLikes-1; | ||
| return updatedChatEntry; | ||
| } else { | ||
| return chat; | ||
| } | ||
| }); | ||
| setMessageData(entries); | ||
| }; | ||
|
|
||
| return ( | ||
| <div id="App"> | ||
| <header> | ||
| <h1>Application title</h1> | ||
| <h1>Chat between VLadimir and Estragon | ||
| <section> | ||
| <p className="widget" id="heartWidget"> | ||
| {numberOfLikes} ❤️s | ||
| </p> | ||
| </section> | ||
| </h1> | ||
| </header> | ||
| <main> | ||
| {/* Wave 01: Render one ChatEntry component | ||
| Wave 02: Render ChatLog component */} | ||
|
|
||
| {/* Wave 01 */} | ||
| {/* <ChatEntry | ||
| sender = {chatMessages[0].sender} | ||
| body = {chatMessages[0].body} | ||
| timeStamp = {chatMessages[0].timeStamp} | ||
| > | ||
| </ChatEntry> */} | ||
|
|
||
| <ChatLog | ||
| entries={MessageData} | ||
| onUpdatechat={updateMessageData}> | ||
| </ChatLog> | ||
|
|
||
| </main> | ||
| </div> | ||
| ); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,44 @@ | ||
| import React from 'react'; | ||
| import './ChatEntry.css'; | ||
| import PropTypes from 'prop-types'; | ||
| import TimeStamp from './TimeStamp'; | ||
|
|
||
| const ChatEntry = (props) => { | ||
| const onFlipHeartClick = () => { | ||
|
|
||
| const updatedChatEntry = { | ||
| id : props.id, | ||
| sender : props.sender, | ||
| body : props.body, | ||
| timeStamp : props.timeStamp, | ||
| liked : !props.liked | ||
| }; | ||
| props.onUpdate(updatedChatEntry); | ||
| }; | ||
|
Comment on lines
+7
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would consider passing the This made me think of a related concept in secure design for APIs. Imagine we had an API for creating and updating messages, and it has an endpoint |
||
| const HeartColor = props.liked ? '❤️':'🤍'; | ||
| return ( | ||
| <div className="chat-entry local"> | ||
| <h2 className="entry-name">Replace with name of sender</h2> | ||
| <div | ||
| className={'chat-entry ' + (props.sender === 'Vladimir' ? 'local' : 'remote')}> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having the decision logic in the JSX may make it harder to read quickly. Another option could be to have an interpolated string here that always holds const entryClassName = (props.sender === 'Vladimir') ? 'local' : 'remote';
...
<div className={`chat-entry ${entryClassName}`}> |
||
| <h2 className="entry-name">{props.sender}</h2> | ||
| <section className="entry-bubble"> | ||
| <p>Replace with body of ChatEntry</p> | ||
| <p className="entry-time">Replace with TimeStamp component</p> | ||
| <button className="like">🤍</button> | ||
| <p>{props.body}</p> | ||
| <p className="entry-time"><TimeStamp time = {props.timeStamp}/></p> | ||
| <button onClick={onFlipHeartClick}className="like" > | ||
| {HeartColor} | ||
| </button> | ||
|
|
||
| </section> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| ChatEntry.propTypes = { | ||
| //Fill with correct proptypes | ||
| id: PropTypes.number, | ||
| sender: PropTypes.string, | ||
| body: PropTypes.string, | ||
| timeStamp: PropTypes.string, | ||
| liked: PropTypes.bool, | ||
| onUpdate: PropTypes.func, | ||
| }; | ||
|
|
||
| export default ChatEntry; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import React from 'react'; | ||
| import './ChatLog.css'; | ||
| import PropTypes from 'prop-types'; | ||
| import ChatEntry from './ChatEntry'; | ||
|
|
||
| const ChatLog = (props) => { | ||
| const chatentryComponents =props.entries.map((chat,index)=>{ | ||
| return ( | ||
| <div key={index} className="chat-log"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the messages all have unique ids, then we could use those values for the |
||
| <ChatEntry | ||
| id = {chat.id} | ||
| sender ={chat.sender} | ||
| body = {chat.body} | ||
| timeStamp = {chat.timeStamp} | ||
| liked = {chat.liked} | ||
| onUpdate = {props.onUpdatechat} | ||
| ></ChatEntry> | ||
| </div> | ||
| ); | ||
| }); | ||
| return ( | ||
| <section> | ||
| <h2>Chat</h2> | ||
| <ul> | ||
| {chatentryComponents}; | ||
| </ul> | ||
| </section> | ||
| ); | ||
| }; | ||
|
|
||
| ChatLog.propTypes = { | ||
| entries: PropTypes.arrayOf(PropTypes.shape({ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Really nice use of PropTypes. |
||
| id:PropTypes.number, | ||
| sender: PropTypes.string, | ||
| body: PropTypes.string, | ||
| timeStamp: PropTypes.string, | ||
| liked: PropTypes.bool, | ||
| }) | ||
| ).isRequired, | ||
|
|
||
| onUpdatechat: PropTypes.func | ||
| }; | ||
|
|
||
| export default ChatLog; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could combine the react imports into a single line: