Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: White screen after clicking "Continue" after setting up account linking with GoCardless #4039

Open
1 task done
takkaria opened this issue Dec 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@takkaria
Copy link

takkaria commented Dec 25, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I repeatedly tried to set up my bank account syncing via GoCardless. I exceeded a limit by my institution while doing this, apparently –

(in the JS console, network tab, I can see a request to https://precise-dragon.pikapod.net/gocardless/get-accounts while setting up sync returned:)

{
    "status": "ok",
    "data": {
        "error_code": "INTERNAL_ERROR",
        "error_type": "Daily request limit set by the Institution has been exceeded"
    }
}

But this error doesn't make it to the UI. Instead, the UI says the setup went fine and if I click the 'continue' button I can set up which accounts get synced - but if I do that, I get a white screen.

The JS console error then is

Uncaught TypeError: Cannot read properties of undefined (reading 'sort')

at this line:

externalAccounts.sort((a, b) => a.name.localeCompare(b.name));

in SelectLinkedAccountsModal.jsx:34.

I can see that GoCardless (by listing requisitions using the API) has successfully authorised the account by something has clearly fallen over in the process.

How can we reproduce the issue?

  1. Click 'add account' on sidebar
  2. Choose to link using GoCardless
  3. Go through GoCardless registration setup
  4. Get back to Actual, wait for "waiting for GoCardless..." to disappear and the Continue button to appear
  5. Click the Continue button

Where are you hosting Actual?

Pikapods

What browsers are you seeing the problem on?

Chrome, Safari

Operating System

Mac OSX

@takkaria takkaria added the bug Something isn't working label Dec 25, 2024
@bramhoven
Copy link

I have this same issue for one of my accounts. I can link another account with the same institution without a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants