Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 404 error page renders literal {errorText} #135

Open
iridiankin opened this issue Feb 17, 2022 · 1 comment
Open

The 404 error page renders literal {errorText} #135

iridiankin opened this issue Feb 17, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@iridiankin
Copy link

Expected behavior:

The 404 result presents the actual internal error text in development environments

Actual behavior:

Literal {errorText} is rendered which is a bit less than useful for debugging purposes.

Steps to fix the problem:

In async responseAsError(errorText, statusCode) replace

  <body>
    {{errorText}}
  </body>

with

  <body>
    ${errorText}
  </body>

or similar.
@activescott
Copy link
Owner

thanks for reporting this one. I'd be grateful for a PR to help fix this one!

@activescott activescott added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@activescott @iridiankin