feat: minimize required getDeposit params (#43)

* feat: minimize required `getDeposit` params

* chore: add changset

Author: dohaki

.changeset/little-pans-explain.md

@@ -0,0 +1,5 @@
+---
+"@across-protocol/app-sdk": patch
+---
+
+decrease required `getDeposit` params

apps/example/scripts/sdk.ts

@@ -194,8 +194,6 @@ async function main() {
   const depositFilter = {
     originChainId: 42161,
     destinationChainId: 10,
-    originSpokePoolAddress: "0xe35e9842fceaCA96570B734083f4a58e8F7C5f2A",
-    destinationSpokePoolAddress: "0x6f26Bf09B1C792e3228e5467807a900A503c0281",
   } as const;
   const depositByTxHash = await client.getDeposit({
     findBy: {

packages/sdk/src/client.ts

@@ -145,6 +145,7 @@ export class AcrossClient {
   private walletClient?: ConfiguredWalletClient;
   private apiUrl: string;
   private indexerUrl: string;
+
   logger: LoggerT;
 
   // Tenderly related options
@@ -251,7 +252,7 @@ export class AcrossClient {
         acrossChains.map((acrossChain) => [acrossChain.chainId, acrossChain]),
       );
     }
-    if (this.chainInfo.has(chainId)) {
+    if (!this.chainInfo.has(chainId)) {
       throw new Error(`Could not find chainInfo for chain with id ${chainId}`);
     }
 
@@ -566,11 +567,32 @@ export class AcrossClient {
   async getDeposit(
     params: Omit<
       GetDepositParams,
-      "originChainClient" | "destinationChainClient" | "indexerUrl"
-    >,
+      "originChainClient" | "destinationChainClient" | "indexerUrl" | "findBy"
+    > & {
+      findBy: {
+        originSpokePoolAddress?: Address;
+        destinationSpokePoolAddress?: Address;
+        originChainId: number;
+        destinationChainId: number;
+        depositId?: number;
+        depositTxHash?: Hex;
+      };
+    },
   ) {
+    const originSpokePoolAddress =
+      params.findBy.originSpokePoolAddress ??
+      (await this.getSpokePoolAddress(params.findBy.originChainId));
+    const destinationSpokePoolAddress =
+      params.findBy.destinationSpokePoolAddress ??
+      (await this.getSpokePoolAddress(params.findBy.destinationChainId));
+
     return getDeposit({
       ...params,
+      findBy: {
+        ...params.findBy,
+        originSpokePoolAddress,
+        destinationSpokePoolAddress,
+      },
       indexerUrl: this.indexerUrl,
       originChainClient: this.getPublicClient(params.findBy.originChainId),
       destinationChainClient: this.getPublicClient(