feat: Added upgradeToAndCall to Spoke Pool Upgrade task (#1095)

* feat: Try upgradeTo for testing

Signed-off-by: Faisal Usmani <[email protected]>

* Added pause deposits toggle to spoke pool upgrade script

Signed-off-by: Faisal Usmani <[email protected]>

* Added option to only do upgrade

Signed-off-by: Faisal Usmani <[email protected]>

* Added comment explaning the multicall

Signed-off-by: Faisal Usmani <[email protected]>

* update comment

Co-authored-by: nicholaspai <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>

* Using abi from artifact

Signed-off-by: Faisal Usmani <[email protected]>

* Dropped optional param

Signed-off-by: Faisal Usmani <[email protected]>

* feat: Upgrade CCTP V1 deployments to V2

* latest

* deploy arbitrum

* arbitrum

* deploy optimism

* optimism

* deplooy optimism spoke pool and polygon adapter

* update

* deploy polygon spoke

* polygon deployed

* Deploy base and unichain adapters

* deployments

* Deploy unichain and base spoke pools

* pdate deployed

* Update upgradeSpokePool.ts

* removed unsed var

Signed-off-by: Faisal Usmani <[email protected]>

* upgrade forge-std

Signed-off-by: Faisal Usmani <[email protected]>

* pin forge-std version

Signed-off-by: Faisal Usmani <[email protected]>

* forge install foundry-rs/forge-std

* Update upgradeSpokePool.ts

---------

Signed-off-by: Faisal Usmani <[email protected]>
Co-authored-by: nicholaspai <[email protected]>
Co-authored-by: nicholaspai <[email protected]>

Author: fusmanii

tasks/upgradeSpokePool.ts

@@ -12,14 +12,30 @@ task("upgrade-spokepool", "Generate calldata to upgrade a SpokePool deployment")
 
     const { ethers } = hre;
 
+    const artifact = await hre.artifacts.readArtifact("SpokePool");
+
     // @dev Any spoke pool's interface can be used here since they all should have the same upgradeTo function signature.
-    const abi = ["function upgradeTo(address newImplementation) external"];
+    const abi = artifact.abi;
     const spokePool = new ethers.Contract(implementation, abi);
 
-    const upgradeTo = spokePool.interface.encodeFunctionData("upgradeTo", [implementation]);
-    console.log(`upgradeTo bytes: `, upgradeTo);
+    let calldata = "";
+
+    /**
+     * We perform this seemingly unnecessary pause/unpause sequence because we want to ensure that the
+     * upgrade is successful and the new implementation gets forwarded calls by the proxy contract as expected
+     *
+     * Since the upgrade and call happens atomically, the upgrade will revert if the new implementation
+     * is not functioning correctly.
+     */
+    const data = spokePool.interface.encodeFunctionData("multicall", [
+      [
+        spokePool.interface.encodeFunctionData("pauseDeposits", [true]),
+        spokePool.interface.encodeFunctionData("pauseDeposits", [false]),
+      ],
+    ]);
 
+    calldata = spokePool.interface.encodeFunctionData("upgradeToAndCall", [implementation, data]);
     console.log(
-      `Call relaySpokePoolAdminFunction() with the params [<chainId>, ${upgradeTo}] on the hub pool from the owner's account.`
+      `Call relaySpokePoolAdminFunction() with the params [<chainId>, ${calldata}] on the hub pool from the owner's account.`
     );
   });