improve: Move BytesLib to external folder (#1153)

* improve: Move BytesLib to external folder

Signed-off-by: Faisal Usmani <[email protected]>

* Undo var scoping

Signed-off-by: Faisal Usmani <[email protected]>

---------

Signed-off-by: Faisal Usmani <[email protected]>

Author: fusmanii

contracts/libraries/BytesLib.sol renamed to contracts/external/libraries/BytesLib.sol

@@ -6,21 +6,25 @@ library BytesLib {
      *              ERRORS                *
      **************************************/
     error OutOfBounds();
-    error InvalidBytes();
-    error InvalidStart();
 
     /**************************************
      *              FUNCTIONS              *
      **************************************/
 
+    // The following 4 functions are copied from solidity-bytes-utils library
+    // https://github.com/GNSPS/solidity-bytes-utils/blob/fc502455bb2a7e26a743378df042612dd50d1eb9/contracts/BytesLib.sol#L323C5-L398C6
+    // Code was copied, and slightly modified to use revert instead of require
+
     /**
      * @notice Reads a uint16 from a bytes array at a given start index
      * @param _bytes The bytes array to convert
      * @param _start The start index of the uint16
      * @return result The uint16 result
      */
     function toUint16(bytes memory _bytes, uint256 _start) internal pure returns (uint16 result) {
-        require(_bytes.length >= _start + 2, "toUint16_outOfBounds");
+        if (_bytes.length < _start + 2) {
+            revert OutOfBounds();
+        }
 
         // solhint-disable-next-line no-inline-assembly
         assembly {
@@ -81,6 +85,8 @@ library BytesLib {
 
     /**
      * @notice Reads a bytes array from a bytes array at a given start index and length
+     * Source: https://github.com/Vectorized/solady/blob/21202175063a0010826bf42697b5aa2ff0c27f9f/src/utils/LibBytes.sol#L369C5-L396C6
+     * Code was copied, was not modified
      * @param _bytes The bytes array to convert
      * @param _start The start index of the bytes array
      * @param _end The end index of the bytes array

contracts/external/libraries/MinimalLZOptions.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.23;
 
-import { BytesLib } from "../../libraries/BytesLib.sol";
+import { BytesLib } from "../../external/libraries/BytesLib.sol";
 import { SafeCast } from "@openzeppelin/contracts/utils/math/SafeCast.sol";
 
 /**

contracts/libraries/SponsoredCCTPQuoteLib.sol

@@ -4,7 +4,7 @@ pragma solidity ^0.8.0;
 import { SignatureChecker } from "@openzeppelin/contracts/utils/cryptography/SignatureChecker.sol";
 
 import { SponsoredCCTPInterface } from "../interfaces/SponsoredCCTPInterface.sol";
-import { BytesLib } from "./BytesLib.sol";
+import { BytesLib } from "../external/libraries/BytesLib.sol";
 import { Bytes32ToAddress } from "./AddressConverters.sol";
 
 /**

contracts/periphery/mintburn/sponsored-oft/ComposeMsgCodec.sol

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: BUSL-1.1
 pragma solidity ^0.8.23;
-import { BytesLib } from "../../../libraries/BytesLib.sol";
+import { BytesLib } from "../../../external/libraries/BytesLib.sol";
 
 /// @notice Codec for params passed in OFT `composeMsg`.
 library ComposeMsgCodec {