WIP

Signed-off-by: Chris Maree <[email protected]>

Author: chrismaree

test/evm/foundry/local/SpokePoolDeprecatedMethods.t.sol

@@ -58,13 +58,17 @@ contract SpokePoolOverloadedDeprecatedMethodsTest is Test {
         mockWETH.deposit{ value: depositAmount }();
         mockWETH.approve(address(spokePool), depositAmount);
         vm.stopPrank();
+
+        // Assert that the spokePool balance is zero at the start
+        assertEq(mockWETH.balanceOf(address(spokePool)), 0, "SpokePool balance should be zero at setup");
     }
 
     function testDeprecatedDeposit() public {
         // Here, we are calling the deprecated deposit method, as defined in the deprecated interface. This should, in
         // theory, collide with the function selector depositDeprecated_5947912356, thereby calling the legacy deposit
         // method on the spoke pool, while using the old old deposit function signature.
         vm.startPrank(depositor);
+
         DeprecatedSpokePoolInterface(address(spokePool)).deposit(
             depositor, // recipient
             address(mockWETH), // originToken
@@ -76,6 +80,8 @@ contract SpokePoolOverloadedDeprecatedMethodsTest is Test {
             0 // maxCount
         );
 
+        assertEq(mockWETH.balanceOf(address(spokePool)), depositAmount, "SpokePool balance should increase");
+
         // Test depositing native ETH directly
         DeprecatedSpokePoolInterface(address(spokePool)).deposit{ value: depositAmount }(
             depositor, // recipient
@@ -88,10 +94,13 @@ contract SpokePoolOverloadedDeprecatedMethodsTest is Test {
             0 // maxCount
         );
         vm.stopPrank();
+
+        assertEq(mockWETH.balanceOf(address(spokePool)), depositAmount * 2, "SpokePool balance should increase");
     }
 
     function testBytes32Deposit() public {
         vm.prank(depositor);
+
         // Show the bytes32 variant of the new deposit method works.
         spokePool.deposit(
             address(depositor).toBytes32(), // depositor
@@ -107,6 +116,8 @@ contract SpokePoolOverloadedDeprecatedMethodsTest is Test {
             0, // exclusivityParameter
             bytes("") // message
         );
+
+        assertEq(mockWETH.balanceOf(address(spokePool)), depositAmount, "SpokePool balance should increase");
     }
 
     function testAddressDeposit() public {
@@ -126,5 +137,7 @@ contract SpokePoolOverloadedDeprecatedMethodsTest is Test {
             0, // exclusivityParameter
             bytes("") // message
         );
+
+        assertEq(mockWETH.balanceOf(address(spokePool)), depositAmount, "SpokePool balance should increase");
     }
 }

test/evm/hardhat/SpokePool.Deposit.ts

@@ -345,6 +345,44 @@ describe("SpokePool Depositor Logic", async function () {
       ).to.emit(spokePool, "FundsDeposited");
     }
   });
+  it.only("should call legacy deposit through overloaded interface", async function () {
+    // Define the deprecated interface
+    const DeprecatedSpokePoolInterface = new ethers.utils.Interface([
+      "function deposit(address recipient, address originToken, uint256 amount, uint256 destinationChainId, int64 relayerFeePct, uint32 quoteTimestamp, bytes memory message, uint256 maxCount) external payable",
+    ]);
+
+    // Create a new instance of the SpokePool with the deprecated interface
+    const deprecatedSpokePool = new ethers.Contract(spokePool.address, DeprecatedSpokePoolInterface, depositor);
+
+    // Call the deprecated deposit method
+    await expect(
+      await deprecatedSpokePool.deposit(
+        depositor.address, // recipient
+        erc20.address, // originToken
+        amountToDeposit, // amount
+        destinationChainId, // destinationChainId
+        0, // relayerFeePct
+        quoteTimestamp, // quoteTimestamp
+        "0x", // message
+        0 // maxCount
+      )
+    ).to.emit(spokePool, "FundsDeposited");
+
+    // Test depositing native ETH directly
+    await expect(
+      deprecatedSpokePool.deposit(
+        depositor.address, // recipient
+        weth.address, // originToken - still WETH address for native deposits
+        amountToDeposit, // amount
+        destinationChainId, // destinationChainId
+        0, // relayerFeePct
+        quoteTimestamp, // quoteTimestamp
+        "0x", // message
+        0, // maxCount
+        { value: amountToDeposit } // Send ETH
+      )
+    ).to.emit(spokePool, "FundsDeposited");
+  });
 
   describe("deposit V3", function () {
     let relayData: V3RelayData, depositArgs: any[];