Skip to content

Minor changes to Servers.xml#185

Closed
LingradAC wants to merge 1 commit intoacresources:masterfrom
LingradAC:master
Closed

Minor changes to Servers.xml#185
LingradAC wants to merge 1 commit intoacresources:masterfrom
LingradAC:master

Conversation

@LingradAC
Copy link
Contributor

Changes:

  1. Removed extra indentation from several elements.
  2. Fixed invalid Reefcull Discord link (from ".com" to ".gg").
  3. Fixed SOME punctuation and spelling, but this is not my main focus.

Changes:
1. Removed extra indentation from several <ServerItem> elements.
2. Fixed invalid Reefcull Discord link (from ".com" to ".gg").
3. Fixed SOME punctuation, but this is not my main focus.
@amoeba
Copy link
Collaborator

amoeba commented Nov 15, 2025

Hi @LingradAC, thanks for the PR. It's a loose policy of mine that all server information is kept as the server admin provided it, typos and all.

The fix for the Reefcull invite URL looks fine though, can you simplify this PR to be just that change? Everything else can be discarded.

@Splatterghast
Copy link
Collaborator

Splatterghast commented Nov 15, 2025

Please do not make any changes for GDLE without consulting me. DM me on discord. Morosity

@amoeba
Copy link
Collaborator

amoeba commented Nov 15, 2025

Please do not make any changes for GDLE without consulting me. DM me on discord. Morosity

It'd be better if discussions happened here. Am I understanding you right that you don't want your Discord URL fixed?

@Splatterghast
Copy link
Collaborator

I would ask that proposed changes, even fixes, be brought to my attention first for Reefcull/Harvestbud before a PR made.

@amoeba
Copy link
Collaborator

amoeba commented Nov 15, 2025

That's fair, though I also think it's fair to say the community owns the record and you've enabled your community to create Discord invites on your behalf.

I'll close this PR and will promptly review a PR with a fix you want to create one.

@amoeba amoeba closed this Nov 15, 2025
@Splatterghast
Copy link
Collaborator

Discord making that change is on them. That ".com" linked worked for many years. I was not aware that Discord had retired that nomenclature. I will create a new .gg link and update the XML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants