Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #3057 where timestamp is not set when using --disable-download-validation #3064

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Fix issue #3057 where timestamp is not set when using --disable-download-validation #3064

merged 2 commits into from
Jan 12, 2025

Conversation

abraunegg
Copy link
Owner

  • When --disable-download-validation is used, we still need to set the file timestamp correctly to avoid integrity checking issues
  • Implement setFileTimestamp() as a common function so that when setting a file timestamp this is done in a consistent manner

@abraunegg
Fix issue #3057
2483cb3 
* When --disable-download-validation is used, we still need to set the file timestamp correctly to avoid integrity checking issues
* Implement setFileTimestamp() as a common function so that when setting a file timestamp this is done in a consistent manner
@abraunegg abraunegg added this to the v2.5.4 milestone Jan 11, 2025
@abraunegg abraunegg linked an issue Jan 11, 2025 that may be closed by this pull request
Bug: Local File Time Discrepancy Issue #3057
Closed
@abraunegg
Update PR
16fbc44 
* Update debug logging ti be more agnostic to support either file or directory use
* Use same function for files and directories to ensure consistency
* Update function to detail what is being set, when it is set, and when it is successful
@abraunegg abraunegg merged commit c7037f8 into master Jan 12, 2025
10 checks passed
@abraunegg abraunegg deleted the fix-issue-3057 branch January 13, 2025 05:19
@abraunegg
Copy link
Owner Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.4
Development

Successfully merging this pull request may close these issues.

Bug: Local File Time Discrepancy Issue
1 participant
@abraunegg