Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse the noceph build flag to ceph #6

Open
robvanmieghem opened this issue Feb 22, 2017 · 1 comment · May be fixed by #7
Open

Reverse the noceph build flag to ceph #6

robvanmieghem opened this issue Feb 22, 2017 · 1 comment · May be fixed by #7

Comments

@robvanmieghem
Copy link

robvanmieghem commented Feb 22, 2017

On a default linux system, without the ceph developer packages installed, the build currently fails:

github.com/ceph/go-ceph/rados/conn.go:5:29: fatal error: rados/librados.h: No such file or directory
 // #include <rados/librados.h>

Wouldn't it be better to reverse the build directive in rbd.go from // +build linux,!noceph to // +build linux,ceph so one can choose to explicitly enable the RbdBackend instead?

This is especially annoying if you want to import the nbd code in an external project where this blocks a normal go get installation.

@abligh
Copy link
Owner

abligh commented Feb 22, 2017 via email

GlenDC added a commit to GlenDC/gonbdserver that referenced this issue Feb 27, 2017
Because of this one has to explicitly specify the  tag
in order to build the go-ceph dependend code.

fixes abligh#6

Signed-off-by: Glen De Cauwsemaecker <[email protected]>
GlenDC added a commit to GlenDC/gonbdserver that referenced this issue Feb 27, 2017
Because of this one has to explicitly specify the  tag
in order to build the go-ceph dependend code.

fixes abligh#6

Signed-off-by: Glen De Cauwsemaecker <[email protected]>
@GlenDC GlenDC linked a pull request Feb 27, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants