-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse the noceph
build flag to ceph
#6
Comments
Hmm... possibly yes. Indeed if I do that, I could just to '// +build ceph' so that ceph could be built on any platform, as ceph client can be built on other OS (at least it could at one stage).
… On 22 Feb 2017, at 08:37, Rob Van Mieghem ***@***.***> wrote:
On a default linux system, without the ceph developer packages installed, the build currently fails.
Wouldn't it be better to reverse the build directive in rbd.go from // +build linux,!noceph to // +build linux,ceph so one can choose to explicitly enable the RbdBackend instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Alex Bligh
|
GlenDC
added a commit
to GlenDC/gonbdserver
that referenced
this issue
Feb 27, 2017
Because of this one has to explicitly specify the tag in order to build the go-ceph dependend code. fixes abligh#6 Signed-off-by: Glen De Cauwsemaecker <[email protected]>
GlenDC
added a commit
to GlenDC/gonbdserver
that referenced
this issue
Feb 27, 2017
Because of this one has to explicitly specify the tag in order to build the go-ceph dependend code. fixes abligh#6 Signed-off-by: Glen De Cauwsemaecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On a default linux system, without the ceph developer packages installed, the build currently fails:
Wouldn't it be better to reverse the build directive in rbd.go from
// +build linux,!noceph
to// +build linux,ceph
so one can choose to explicitly enable the RbdBackend instead?This is especially annoying if you want to import the nbd code in an external project where this blocks a normal
go get
installation.The text was updated successfully, but these errors were encountered: