[Light] :locale prop and :custom-locale prop doesn't work

[mmirandola-igw]

I noticed that the props mentioned doesn't change the plugin language labels, they're remain in the default language ('en')

[abichinger]

Hi,

The locale and custom-locale props seem to work.
I think the issue is that it is not possible to change the language dynamically.

You can bypass this limitation by setting the key attribute.

<template>
  <cron-light :locale="mylocale" :key="mylocale" />
<template>

This will force vue to create a new instance of the component everytime mylocale is changed.

[mmirandola-igw]

Hi, thanks for the info, but setting the :key with the locale has not worked.
There's definitely something I'm doing wrong, but here my code:

In the component I'm using CronLight

<script setup> // Here I import the current app locale using VueI18n import { useI18n } from 'vue-i18n' const { t, locale } = useI18n() </script>

<template> <CronLight v-model="schedule.frequency" :locale="locale.value" /> </template>

In the main.ts where I set the app language (as you can see I'm setting Italian by default, so I'm expecting that, when the component is loaded, the locale.value is setted as "it")

const i18n = createI18n({ legacy: false, locale: 'it', messages: {...messages}, datetimeFormats: { it: dateTimeLocales } })

Thanks for your support

[abichinger]

Your code looks good.

But Italian is currently not supported by this component.

You can define your own Localization with custom-locale
If you end up translating the component to Italian, then please share your Localization object with us.

[mmirandola-igw]

Oh, ok, now I understand why it wasn’t working. I didn’t think of trying other languages, but after setting it to Spanish it actually works, sorry about that.
Of course, once I manage to translate it into Italian with the custom-locale, I’ll be happy to share the Localization object for anyone who might need it in the future.
Thanks a lot!

[mmirandola-igw]

Hi, I've just translated almost all the labels, cloning the entire Localization obj that I found here on locale/en.ts

But, as you can see here, the names of the Months and Weekdays is still in english, and I cannot find a way to translate them (it seems to not be present in the Localization obj)

Oh, and let me know how do you prefer I contribute to giving you the italian version, thank you.

[mmirandola-igw]

Nevermind, I saw that the weekdays names and months are the only things that are translated by using the "locale" prop.
I saw that here in the /core/src/util.ts.
So now, everything is translated, thank you.

[abichinger]

Nice!

Oh, and let me know how do you prefer I contribute to giving you the italian version, thank you.

It would be awesome if you could create a Pull Request for it. (Contributing guidlines)

If a PR is too much effort, you can simply paste the Localization object here.

[mmirandola-igw]

Hi @abichinger, I've just created the PR for it. Check it out ;-) thanks

[abichinger]

Hi @mmirandola-igw, thank you for the PR. I've merged it into the develop branch.
I'm going to release it soon.

[abichinger]

@mmirandola-igw, the Italian translation is now part of @vue-js-cron/light@5.1.0 🎉