Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't "from <module> import <class> on bare .py files in a package. Instead use __all__ #22

Open
terrysimons opened this issue Apr 8, 2015 · 0 comments
Open

Don't "from <module> import <class> on bare .py files in a package. Instead use __all__ #22

terrysimons opened this issue Apr 8, 2015 · 0 comments

Comments

@terrysimons
Copy link

The current implementation breaks on Python 3 because of the way the modules are being imported internally.

Instead of doing:

from firebase import Firebase

you should do:

__all__ = ['firebase']

This fixes Python 3's ability to import the module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrysimons